-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to store the elements_names for each channel #161
Conversation
src/libYARP_telemetry/src/yarp/telemetry/experimental/BufferConfig.h
Outdated
Show resolved
Hide resolved
fe2b444
to
7571c96
Compare
src/libYARP_telemetry/src/yarp/telemetry/experimental/BufferConfig.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this has been tested both with and without elements_name
is ok for me 👍🏻
Could you please add a test for this new feature added? Thanks!
Hi @Nicogene I updated the documentation 31eba39 and I added a test 9266fd2 I've also noticed that the project version is 0.2.0, even if the current release is 0.4.0. Do you think it is possible to bump the CMake project version to 0.4.100 as soon as this PR is merged so the consumer application can ask for yarp_telementry 0.4.100 to use the new features implemented? |
I'm not able to figure out why the conda ci on windows is failing |
I was able to reproduce the failure locally. |
On Windows yarp-telemetry manages the visibility of functions manually, different from most of our project were we rely on diff --git a/src/libYARP_telemetry/src/yarp/telemetry/experimental/BufferConfig.h b/src/libYARP_telemetry/src/yarp/telemetry/experimental/BufferConfig.h
index ae8bb0e..af19eea 100644
--- a/src/libYARP_telemetry/src/yarp/telemetry/experimental/BufferConfig.h
+++ b/src/libYARP_telemetry/src/yarp/telemetry/experimental/BufferConfig.h
@@ -23,7 +23,7 @@ using elements_names_t = std::vector<std::string>;
* @brief Struct representing a channel(variable) in terms of
* name and dimensions and names of the each element of a variable.
*/
-struct ChannelInfo {
+struct YARP_telemetry_API ChannelInfo {
std::string name; /**< Name of the channel */
dimensions_t dimensions; /**< Dimension of the channel */
elements_names_t elements_names; /**< Vector containing the names of each element of the channel */
fyi @GiulioRomualdi |
Ah good catch! Yes I forgot to bump it, if you can change it otherwise I can do it later thanks! |
I can change it 😄 |
- BufferInfo is now a struct that contains the name, the dimension and the elements_names. - To access the BufferInfo name we should use BufferInfo.name (before was BufferInfo.first) - To access the BufferInfo name we should use BufferInfo.dimensions (before was BufferInfo.second)
cbbc934
to
4c41c74
Compare
I rebased the PR on master and I updated the |
The conda ci is failing on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a new entry for each stored variable called
elements_names
. The entry is a cell that will contain the name of each element of a variable.BufferInfo is now a struct that contains the
name
, thedimension
, and theelements_names
.cc @traversaro @S-Dafarra @Nicogene @AlexAntn