-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add couplingICubHandMk2 device coupling handler #995
Add couplingICubHandMk2 device coupling handler #995
Conversation
This work bring to light a thing to be understand/discussed related to devices that are outside the YARP repository but want to exploit the param parser generation feature.
We added inside the relative devices' CMakeLists: option(ALLOW_DEVICE_PARAM_PARSER_GENERATION "Generate the param parser for foo device" OFF) this option is forwarded in order to enable the parser generation. @randaz81 is it the correct way the external repositories for exploiting this new feature? |
I guess that we can simply leave the option not set, as we do for the similar |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 8 changed files in this pull request and generated 18 suggestions.
Files not reviewed (5)
- src/libraries/icubmod/CMakeLists.txt: Language not supported
- src/libraries/icubmod/couplingICubHandMk2/CMakeLists.txt: Language not supported
- src/libraries/icubmod/couplingICubHandMk2/CouplingICubHandMk2.cpp: Language not supported
- src/libraries/icubmod/couplingICubHandMk2/CouplingICubHandMk2.h: Language not supported
- src/libraries/icubmod/couplingICubHandMk2/CouplingICubHandMk2_ParamsParser.h: Language not supported
src/libraries/icubmod/couplingICubHandMk2/CouplingICubHandMk2_params.md
Outdated
Show resolved
Hide resolved
src/libraries/icubmod/couplingICubHandMk2/CouplingICubHandMk2_params.md
Outdated
Show resolved
Hide resolved
src/libraries/icubmod/couplingICubHandMk2/CouplingICubHandMk2_params.md
Outdated
Show resolved
Hide resolved
src/libraries/icubmod/couplingICubHandMk2/CouplingICubHandMk2_params.md
Outdated
Show resolved
Hide resolved
src/libraries/icubmod/couplingICubHandMk2/CouplingICubHandMk2_params.md
Outdated
Show resolved
Hide resolved
1d38a6a
to
b371828
Compare
In: I managed to merge all the coupling handlers (we used to have one separated per finger) into one.
disableImplicitNetworkWrapper
yarpDeviceName left_hand_hardware_device
jointNames l_hand_thumb_0_joint l_hand_thumb_1_joint l_hand_thumb_2_joint l_hand_thumb_3_joint l_hand_index_0_joint l_hand_index_1_joint l_hand_index_2_joint l_hand_index_3_joint l_hand_middle_0_joint l_hand_middle_1_joint l_hand_middle_2_joint l_hand_middle_3_joint l_hand_ring_0_joint l_hand_ring_1_joint l_hand_ring_2_joint l_hand_ring_3_joint l_hand_little_0_joint l_hand_little_1_joint l_hand_little_2_joint l_hand_little_3_joint
min_stiffness 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
max_stiffness 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0 1000.0
min_damping 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
max_damping 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0
[TRAJECTORY_GENERATION]
trajectory_type minimum_jerk
[COUPLING]
device couplingICubHandMk2
actuatedAxesNames l_hand_finger l_thumb_oppose l_thumb_proximal l_thumb_distal l_index_proximal l_index_distal l_middle_proximal l_middle_distal l_pinky
actuatedAxesPosMin 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
actuatedAxesPosMax 60.0 90.0 90.0 180.0 90.0 180.0 90.0 180.0 270.0
[POSITION_CONTROL]
controlUnits metric_units
controlLaw joint_pid_gazebo_v1
kp 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1 0.1
kd 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01 0.01
ki 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
maxInt 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999
maxOutput 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999
shift 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
ko 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
stictionUp 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
stictionDwn 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
[VELOCITY_CONTROL]
velocityControlImplementationType integrator_and_position_pid
controlUnits metric_units
controlLaw joint_pid_gazebo_v1
kp 8.726 8.726 8.726 5.235 8.726 8.726 8.726 5.235 8.726 8.726 8.726 8.726 8.726 8.726 8.726 8.726 8.726 8.726 8.726 8.726
kd 0.035 0.035 0.035 0.002 0.035 0.035 0.035 0.002 0.035 0.035 0.035 0.035 0.035 0.035 0.035 0.035 0.035 0.035 0.035 0.035
ki 0.002 0.002 0.002 0.0 0.002 0.002 0.002 0.0 0.002 0.002 0.002 0.002 0.002 0.002 0.002 0.002 0.002 0.002 0.002 0.002
maxInt 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999
maxOutput 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999 9999
shift 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
ko 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
stictionUp 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
stictionDwn 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
[IMPEDANCE_CONTROL]
controlUnits metric_units
controlLaw joint_pid_gazebo_v1
stiffness 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
damping 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0
[LIMITS]
jntPosMax 0.0 0.0 20.0 20.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0 90.0
jntPosMin -20.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0. 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 90.0 90.0
jntVelMax 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0 100.0
|
Still WIP, right now it is just a copy of CouplingXCubHandMk5
b371828
to
fd86701
Compare
This PR has been tested with: @pattacini @traversaro it is ready to be reviewed/merged |
This PR adds the
couplingICubHandMk2
device driver, that implement the IJointCoupling interface: