-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frames of skin-related quantities #124
Comments
@traversaro I still have to finish reading, but currently on the skinManager the index of the |
Keeping that convention would make more sense in order to not break compatibility. Furthermore, it is more consistent with the leg convention. |
I had to solve this issue while programming the skin emulation for the simulator. My code and notes were:
I was checking this in the iCubGui and with Alessandro Scalzo, so this is the convention apparently (at least the one adopted back then). That is using the iKinInertialSensor and link 2. |
Creating a new ad-hoc chain (that does not depend on neck versions and goes up to the neck base) would likely solve the issue. @pattacini what do you think? |
I am inclined to support this suggestion, it would simplify a lot configuration files. |
I'll do that. |
I'm done with |
@traversaro how would you relate this issue with the |
@traversaro @jeljaik slightly related to this topic (and #149 ), do you have any idea about why the torso position file (i.e. https://github.com/robotology/icub-main/blob/master/app/skinGui/conf/positions/torso.txt ) is filled with 768 lines of |
If I'm not wrong, that's because the torso has never been calibrated and
that was manually introduced for some particular experiment in the past.
|
Ok. |
Personally I wouldn't have any complain. Jorhabib Eljaik Gómez,*Ph.D. Student - *Istituto Italiano di Tecnologia On Fri, May 22, 2015 at 3:35 PM, Alessandro Roncone <
|
…d put it back to empty calibrations (ref robotology#124)
|
Ok. I'll move back to the previous version. |
🔝 |
and support sdformat 3
This should be solved by now. |
For expressing information related to the skin (the one published by the skinManager and the wholeBodyDynamicsTree on the
*contacts:o*
ports using theskinDynLib
data structures) we have to define for each link the frame in which we want to express this informations, such as taxels position and force/torque orientation.For discussing this issue, I will use the convention discussed in #57 (soon to be transformed in proper documentation).
Existing convention
For the links on which the skin is used, the frame of expression is the one indicated in the following table:
SKIN_LEFT_UPPER_ARM
SKIN_LEFT_FOREARM
SKIN_LEFT_HAND
SKIN_RIGHT_UPPER_ARM
SKIN_RIGHT_FOREARM
SKIN_RIGHT_HAND
Extensions to existing convention
For the skin patches in the leg no frame is currently used, but assuming a convention similar to the one used in arms a possible choice could be:
LEFT_UPPER_LEG
LEFT_LOWER_LEG
LEFT_FOOT
RIGHT_UPPER_LEG
RIGHT_LOWER_LEG
RIGHT_FOOT
Notice that while for intermediate link the frame is defined by the DH convention, for the end effector frame is just a choice independent from the DH convention, so perhaps the
*_dh_frame
name could be misleading.@alecive can you review
iKinChain
link numbers?Problems with extending the existing convention on
chest
skinHowever, the existing convention of using DH frames cannot be strictly followed for the
chest
link, SkinPart nameSKIN_FRONT_TORSO
. The main problem is that thechest
link for the DH convention used by iKin for frame placement has three different frames, depending on which chain is considered (if head, right arm or left arm).We started discussing this issue informally with @alecive , and he was proposing to use the
chest
frame in thehead
DH chain (as defined in http://eris.liralab.it/wiki/ICubInertiaSensorKinematics and http://eris.liralab.it/wiki/ICubInertiaSensorKinematicsV2 ) because it is a frame that respect the left-right simmetry of the robot. The main problem that I see in this proposed is that in this case the taxel position files for theSKIN_FRONT_TORSO
(the one loaded by the skinManager) should be different between robots with V1 neck (such as iCubParis01) and the V2 neck, even if the taxel position (with respect to the root_link) are the same.cc (people I assume could be interested in skin issues) @jeljaik @alecive @lornat75 @matejhof @naveenoid
The text was updated successfully, but these errors were encountered: