Avoid to append GAZEBO_CXX_FLAGS to CMAKE_CXX_FLAGS #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GAZEBO_CXX_FLAGS was added to CMAKE_CXX_FLAGS in #190 to support compilation against Gazebo 6 that required C++11, and unfortunately since then Gazebo did not switch to a modern way of specifying C++ standard requirement in consuming libraries. Now that YARP requires C++14, passing GAZEBO_CXX_FLAGS (that contains -std=c++11) basically bypass the CMake logic to compute the correct C++ standard with which to compile the plugins, and forces to compile them with C++11. As the only reason for which GAZEBO_CXX_FLAGS was added to CMAKE_CXX_FLAGS was to enable C++11 support, and as that is already passed as a requirement by YARP, I think we can just remove it. Related SDFormat PR: gazebosim/sdformat#251 .
This was referenced Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAZEBO_CXX_FLAGS was added to CMAKE_CXX_FLAGS in #190 to support compilation against Gazebo 6 that required C++11, and unfortunately since then Gazebo did not switch to a modern way of specifying C++ standard requirement in consuming libraries. Now that YARP requires C++14, passing GAZEBO_CXX_FLAGS (that contains
-std=c++11) basically bypass the CMake logic to compute the correct C++ standard with which to compile the plugins, and forces to compile them with C++11.As the only reason for which GAZEBO_CXX_FLAGS was added to CMAKE_CXX_FLAGS was to enable C++11 support, and as that is already passed as a requirement by YARP targets, I think we can just remove it.
Related SDFormat PR: gazebosim/sdformat#251 .
Fix robotology/robotology-superbuild#426 .