Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

updated icub nancy urdf for balancing and standup #80

Merged
merged 5 commits into from
Jul 28, 2017

Conversation

gabrielenava
Copy link
Collaborator

@gabrielenava gabrielenava commented Jul 1, 2017

I updated the model of iCub Nancy that now coincides with the one inside icub-models. Furthermore, I added a model containing also the frames for standup demo (and I verified their pose using rviz)

Verified

This commit was signed with the committer’s verified signature. The key has expired.
chfast Paweł Bylica
@traversaro
Copy link
Contributor

Can you add a short README.md to the iCubNancy01 directory describing the different models? Just simple links to the appropriate GitHub issues will be enough, thanks!

@traversaro
Copy link
Contributor

ping @gabrielenava

@gabrielenava
Copy link
Collaborator Author

done at e91081a


- model.urdf --> it is the one loaded in yarpWholeBodyInterface.ini

- model__BALANCING_IIT.urdf --> it is the model used for YOGA++ demo (the same of https://github.com/robotology-playground/icub-models/tree/master/iCub/robots/iCubNancy01)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model__BALANCING_IIT --> model_BALANCING_IIT


- model__BALANCING_IIT.urdf --> it is the model used for YOGA++ demo (the same of https://github.com/robotology-playground/icub-models/tree/master/iCub/robots/iCubNancy01)

- model__STANDUP.urdf --> it is used for the standup demo (added upper leg contact frames, see https://github.com/robotology-playground/icub-model-generator/issues/42)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model__STANDUP -> model_STANDUP

@traversaro
Copy link
Contributor

I am confused by the models committed in this PR.

model.urdf and model_STANDUP.urdf are identifical. Furthermore, model_BALANCING_IIT.urdf is almost identical to the other two files, with some trivial unrelated modification in the names of the meshes, and with the (l|r)_upper_leg_contact frames removed. If the models are identical modulo some additional frames, why not keep a single model.urdf?

Just to clarify, f2f and in #78 (comment) I proposed to use a separated model for the balancing/standup for iCubNancy based on iCubDarmstadt01 because, while iCubNancy has v1 forearms, I trust better the accuracy of the simmechanics-generated model for the legs and the torso kinematics and dynamics parameters. Furthermore, as far as I remember we extracted the location of the (l|r)_upper_leg_contact frame for simmechanics-generated models, so I do not really understand where do you obtained the location of that frame w.r.t. to the (l|r)_upper_leg link frame for dh-generated models such as the iCubNancy01 one.


- model_BALANCING_IIT.urdf --> it is the model used for YOGA++ demo (the same of https://github.com/robotology-playground/icub-models/tree/master/iCub/robots/iCubNancy01)
- model_STANDUP.urdf --> it is the model used for the standup demo. For the time being, it is identical two model.urdf;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identical two model.urdf; --> identical to

Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

@gabrielenava gabrielenava merged commit e923736 into master Jul 28, 2017
@gabrielenava gabrielenava deleted the update_iCubNancy_model branch July 28, 2017 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants