Issue 1768 #1819
Merged
Issue 1768 #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes robotframework#1768 Now includes utest for setter/getter and test that correct delay is passed to ActionChains() constructor
compatability As with the addition of the page_load_timeout, moved action_chain_delay into the last position so if anyone has poorly structured Library imports (which should be using named arguments) this will not break their implementations.
It looks like the error message on this test has changed. It is unclear at the time what this test is supposed to do and where the expected error message should come in. As such I am going to triage the test for later review.
- Updated number of expected keywords based upon the two added for the setting action_chain_delay - Moved expected position of the action_chain_delay argument documentation to the bottom of the list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to @rasjani's pull request
Fixes #1768