-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non templated problem #97
Conversation
} | ||
|
||
/// \brief Flag representing the Roboptim Function type | ||
static const unsigned long flag_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for a trailing underscore for static parameters, since you call it in a public way, e.g. GenericDifferentiableFunction<T>::flag_
.
001d4fc
to
2a62163
Compare
Ok so now that the Problem and Solver classes are rewritten, we will probably have to provide an "automatic_cast" that uses the flag system to retrieve the actual function. Three tests fail, and it is basically because we can't check the constraint type as before. So something able to retrieve the actual function type would solve it. |
Another idea for the enum: to prevent clashes, we can also wrap it in a struct, cf. what I did there. Also, this PR should not be on master since this is a huge API change. This should be on a separate branch until we give the all clear. |
Indeed, it would be cleaner to base the PR on a related branch, but none of the active branches is really related to it (and many of them are quite old, so the merge process might be complicated) |
I guess we can create a |
9be0985
to
3de331d
Compare
329c9ad
to
a839e67
Compare
Bugfix needed
9b40b50
to
37d1d04
Compare
37d1d04
to
31ec866
Compare
Moving this to a new PR |
Work in progress:
Once over, every plugin and dependent modules will have to be updated accordingly