Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model type for classification #773

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

robiscoding
Copy link
Contributor

Description

  • Classification inference requests don't have a null model_type which is causing downstream issues in Model Monitoring (missing label/misreporting)
  • This change manually sets the classification model type and adds some unit tests

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

  • Tested that classification projects have a defined model_type when making a legacy infer request and checking the item in a local cache
  • Added unit tests for the serializers file

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@robiscoding robiscoding marked this pull request as ready for review November 4, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant