Disable scraping for containers where model_manager is not defined #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbitbus
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
|
@PawelPeczek-Roboflow tested locally for parallel container and it works now. |
PawelPeczek-Roboflow
approved these changes
Oct 18, 2024
PawelPeczek-Roboflow
deleted the
fix/disable-custom-scraping-for-parallel-containers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The parallel containers dont have the model_manager object so custom per-model Prometheus scraping implemented in #750 will not work for them.
This bugfix disables custom prometheus scraping for parallel dockers.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested locally on parallel and non-parallel inference containers.
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs