Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alternate video sources #348

Merged
merged 10 commits into from
Apr 18, 2024
Merged

Allow alternate video sources #348

merged 10 commits into from
Apr 18, 2024

Conversation

sberan
Copy link
Contributor

@sberan sberan commented Apr 10, 2024

Description

This PR adds a VideoFrameProducer class which can be passed as a video source. This allows us to work with video sources that cv2 doesn't support such as basler.

Here is an example script which creates a VideoFrameProducer for a camera which isn't supported by opencv.

@PawelPeczek-Roboflow what do you think of this abstraction? Is there a better way we could be doing this? Should we rename the interface? If you like the abstraction, I will clean it up and add docs and tests.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

tested locally

Any specific deployment considerations

n/a

Docs

  • TODO. the docs will need to be updated

@sberan sberan marked this pull request as ready for review April 17, 2024 21:09
@sberan sberan changed the title [DRAFT] Allow alternate video sources Allow alternate video sources Apr 17, 2024
@sberan sberan merged commit 76a1d56 into main Apr 18, 2024
26 checks passed
@sberan sberan deleted the video-frame-grabber branch April 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants