Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference TensorRT execution provider container revival #347

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

probicheaux
Copy link
Collaborator

@probicheaux probicheaux commented Apr 9, 2024

Description

Revives the trt container, bugfixing engine caching, and disables ORT graph optimizations (since trt can do them better)

Screenshot 2024-04-09 at 4 14 16 PM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Locally

Any specific deployment considerations

New container push

Docs

  • Docs updated? What were the changes:

@@ -604,6 +605,9 @@ def __init__(
"trt_fp16_enable": True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is there any value from making that parametrised by env?

Copy link
Collaborator Author

@probicheaux probicheaux Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling this flag uniformly made inference slower even for unconverted models in my tests

inference/core/models/roboflow.py Outdated Show resolved Hide resolved
@@ -1,5 +1,4 @@
FROM roboflow/roboflow-inference-server-trt-base:latest

FROM nvcr.io/nvidia/tensorrt:22.12-py3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@probicheaux probicheaux merged commit bbeec51 into main Apr 12, 2024
26 checks passed
@probicheaux probicheaux deleted the trt-revival branch April 12, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants