Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Bug #313: Ensure Graceful Interruption of Benchmark Process #325

Merged
merged 2 commits into from
Mar 15, 2024

Commits on Mar 15, 2024

  1. Fix for Bug roboflow#313: Ensure Graceful Interruption of Benchmark P…

    …rocess
    
    This pull request addresses bug roboflow#313, where users were unable to interrupt the benchmarking process using Ctrl+C, leading to a scenario where the benchmark would continue running indefinitely, ignoring interruption requests. The core of the issue was the absence of a proper signal handling mechanism for keyboard interrupts during the execution of the benchmarking commands.
    
    Added a try-except block around the benchmarking execution commands in benchmark.py. This ensures that a KeyboardInterrupt (e.g., through Ctrl+C) is caught, and a graceful shutdown sequence can be initiated.
    Upon catching a KeyboardInterrupt, the script now calls stop_inference_containers() from container_adapter.py. This function halts all running inference containers, ensuring that no orphaned resources are left consuming system resources post-interruption.
    
    Enhanced stop_inference_containers() to handle both interactive and automated environments gracefully.
    hvaria committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    bbf62c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03fb9e3 View commit details
    Browse the repository at this point in the history