Add inference_id to batches created by AL #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +53,7 @@ def execute_datapoint_registration( | |||
| configuration: ActiveLearningConfiguration, | |||
| api_key: str, | |||
| batch_name: str, | |||
| inference_id=None, | |||
There was a problem hiding this comment.
typing hint required
|
Do we still need it? |
By it do you mean do we still need the inference_id? If so, then yes we do. I still need to fix the failing test before this is ready for review (currently a Draft/WIP) |
|
Ready for review |
|
I do not see |
PawelPeczek-Roboflow
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to display inference images in the model monitoring dashboard, we need to add the inference id to the images created from inference requests via the AL workflow
Relates to: https://github.com/roboflow/roboflow/pull/3080
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs