Updated Requirements.cli.txt #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `aiohttp` and `backoff` to the `requirements.cli.txt` file. This ensures that these dependencies are installed alongside `inference_cli`, addressing the root cause of the startup failures. - `aiohttp` and `backoff` are direct dependencies of the `inference_sdk` used by our CLI tool for handling HTTP requests and implementing retry logic, respectively. - The absence of these packages in the `requirements.cli.txt` file led to incomplete environment setup for users, resulting in runtime errors. - By explicitly listing these dependencies, we ensure that the necessary packages are present in the environment, thereby preventing `ModuleNotFoundError` issues during runtime.
|
|
|
@hvaria - thanks for contribution - could u please sign CLA |
|
@PawelPeczek-Roboflow I not sure, why Login to dockerhub failed, overall i just added 2 line to perfect place, for fixing small bug #299 |
|
no worries, this is related to setup that we have in the repo - will be sorted out. Good contribution 👍 |
|
ok, merging - thanks for contribution 🏅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #299
Added
aiohttpandbackoffto therequirements.cli.txtfile. This ensures that these dependencies are installed alongsideinference_cli, addressing the root cause of the startup failures.aiohttpandbackoffare direct dependencies of theinference_sdkused by our CLI tool for handling HTTP requests and implementing retry logic, respectively.The absence of these packages in the
requirements.cli.txtfile led to an incomplete environment setup for users, resulting in runtime errors.By explicitly listing these dependencies, i ensure that the necessary packages are present in the environment, thereby preventing
ModuleNotFoundErrorissues during runtime.