set source on workflow execution inference requests #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pass `workflow-execution` as source on inference requests made by the workflow execution engine so the requests can be id'd as being part of workflow execution
hansent
commented
Feb 28, 2024
| @@ -187,6 +187,7 @@ def construct_classification_request( | |||
| image=image, | |||
| confidence=resolve(step.confidence), | |||
| disable_active_learning=resolve(step.disable_active_learning), | |||
| source="workflow-execution", | |||
There was a problem hiding this comment.
ideally would want to pass source_info as the workflow id/name, but don't have that context available here easily?
There was a problem hiding this comment.
yes, we do not have that
PawelPeczek-Roboflow
approved these changes
Feb 28, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds source and source_info parameters to
InferenceConfigurationand passworkflow-executionas source on inference requests made by the workflow execution engine so the requests can be id'd as being part of workflow executionList any dependencies that are required for this change.
This enables model monitoring to filtr / group by which inference request were made via workflow execution
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
NOT YET!
Any specific deployment considerations
Docs