Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify visualize results example #271

Merged
merged 1 commit into from
Feb 16, 2024
Merged

modify visualize results example #271

merged 1 commit into from
Feb 16, 2024

Conversation

ryanjball
Copy link
Collaborator

Description

Update visualize results documentation, using https://detect.roboflow.com, sv.ImageSink, and fixing from_inference error

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2024

CLA assistant check
All committers have signed the CLA.

@@ -55,22 +55,22 @@ image = cv2.imread(image_file)

#Configure client
client = InferenceHTTPClient(
api_url="http://localhost:9001", # route for local inference server
api_url="https://detect.roboflow.com", # route for local inference server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this URL changing? We're showing how to use Inference on your local server in this guide.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have the localhost example above this in the docs, and it is convenient to copy this whole code snippet to visualize and have it work without having to deploy docker. imo we have too much localhost and not enough detect.roboflow.com

@capjamesg capjamesg self-requested a review February 16, 2024 16:53
@ryanjball ryanjball merged commit 5154556 into main Feb 16, 2024
5 checks passed
@ryanjball ryanjball deleted the visualize_results branch February 16, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants