Internal instrumentations should always be enabled by default (open-t…

…elemetry#3257)
robododge · Jun 17, 2021 · 7e37126 · 7e37126
1 parent db4cdc1
commit 7e37126
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/...etry/javaagent/instrumentation/internal/classloader/ClassLoaderInstrumentationModule.java b/...etry/javaagent/instrumentation/internal/classloader/ClassLoaderInstrumentationModule.java
@@ -18,6 +18,12 @@ public ClassLoaderInstrumentationModule() {
     super("internal-class-loader");
   }
 
+  @Override
+  public boolean defaultEnabled() {
+    // internal instrumentations are always enabled by default
+    return true;
+  }
+
   @Override
   public boolean isHelperClass(String className) {
     return className.equals("io.opentelemetry.javaagent.tooling.Constants");

diff --git a/...entelemetry/javaagent/instrumentation/internal/osgi/EclipseOsgiInstrumentationModule.java b/...entelemetry/javaagent/instrumentation/internal/osgi/EclipseOsgiInstrumentationModule.java
@@ -18,6 +18,12 @@ public EclipseOsgiInstrumentationModule() {
     super("internal-eclipse-osgi");
   }
 
+  @Override
+  public boolean defaultEnabled() {
+    // internal instrumentations are always enabled by default
+    return true;
+  }
+
   @Override
   public List<TypeInstrumentation> typeInstrumentations() {
     return singletonList(new EclipseOsgiInstrumentation());

diff --git a/...io/opentelemetry/javaagent/instrumentation/internal/proxy/ProxyInstrumentationModule.java b/...io/opentelemetry/javaagent/instrumentation/internal/proxy/ProxyInstrumentationModule.java
@@ -18,6 +18,12 @@ public ProxyInstrumentationModule() {
     super("internal-proxy");
   }
 
+  @Override
+  public boolean defaultEnabled() {
+    // internal instrumentations are always enabled by default
+    return true;
+  }
+
   @Override
   public List<TypeInstrumentation> typeInstrumentations() {
     return singletonList(new ProxyInstrumentation());

diff --git a/...avaagent/instrumentation/internal/urlclassloader/UrlClassLoaderInstrumentationModule.java b/...avaagent/instrumentation/internal/urlclassloader/UrlClassLoaderInstrumentationModule.java
@@ -18,6 +18,12 @@ public UrlClassLoaderInstrumentationModule() {
     super("internal-url-class-loader");
   }
 
+  @Override
+  public boolean defaultEnabled() {
+    // internal instrumentations are always enabled by default
+    return true;
+  }
+
   @Override
   public List<TypeInstrumentation> typeInstrumentations() {
     return singletonList(new UrlClassLoaderInstrumentation());