Skip to content
This repository has been archived by the owner on Aug 28, 2022. It is now read-only.

fix(getStyles): styles-as-properties priority #39

Merged
merged 1 commit into from
May 25, 2017
Merged

Conversation

atticoos
Copy link
Contributor

@atticoos atticoos commented May 25, 2017

What: #35 styles-as-properties had lower priority than style property

<glamorous.View
  style={{backgroundColor: 'green'}}
  backgroundColor="blue"
/>
// should have `blue` background

Why: The styles-as-properties should have the highest priority

How: These are now the last styles added to the component's style array

styles as properties now have highest priority

closes #35
@codecov-io
Copy link

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files          10       10           
  Lines         117      117           
  Branches       36       36           
=======================================
  Hits          105      105           
  Misses          8        8           
  Partials        4        4
Impacted Files Coverage Δ
src/get-styles.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535fc2c...a305d85. Read the comment docs.

@atticoos atticoos merged commit 2daf456 into master May 25, 2017
@atticoos atticoos added the bug label May 25, 2017
@atticoos atticoos deleted the style-priorty branch May 25, 2017 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants