build: migrate ngx-deploy-npm to v8 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinpellegrims
requested changes
Jun 27, 2024
|
Thanks for this PR! I just have one remark that is unfortunately blocking the PR, could you take a look? |
robinpellegrims
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
ngx-deploy-npmto v8 to support nx19.ngx-deploy-npm v8 introduced some breaking changes. This PR applies the migration scripts and other necessary changes to adapt version 8 properly.
More information about V8 changes can be found in the blog post What's coming to ngx-deploy-npm V8
Here you can find another PRs upgrading ngx-deploy-npm to v8
jscutlery/semver#772
ngworker/lumberjack#198
code-pushup/cli#427