This repository was archived by the owner on Sep 25, 2021. It is now read-only.
Better trace page search #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nziebart
force-pushed
the
trace-page-search
branch
from
68047e3 to
27c3d2b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the search bar on the trace view page only searches the service name and operation name.
We have a some use cases that aren't satisfied by this. For example:
This change does two things:
a) includes the tag key/value pairs in the searchable content
b) switches from fuzzy to exact search
I found (b) to be necessary from some experimentation - the md5 and SQL queries in particular will match random search queries due to the fuzzy search. Also it feels fairly intuitive to have verbatim search - this is how chrome search works.