Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for acking tombstone messages #442

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

patkivikram
Copy link
Collaborator

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

This fixes the issue of not acking tombstone messages on a topic processed by the agent
#439

@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #442 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #442   +/-   ##
======================================
  Coverage    99.9%   99.9%           
======================================
  Files          95      95           
  Lines        9051    9051           
  Branches     1011    1011           
======================================
  Hits         9042    9042           
  Misses          5       5           
  Partials        4       4
Impacted Files Coverage Δ
faust/streams.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615efd6...b68175b. Read the comment docs.

@ask ask merged commit 90ec8d5 into robinhood:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants