feature: add collection management and related links functionality

[robfrank]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @robfrank, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application by introducing robust collection management and a new related links discovery feature. Users can now organize their links into custom collections, including dynamic 'smart' collections, and easily find other links that are contextually similar based on shared domains or tags. These additions involve comprehensive changes across the application's layers, from new API endpoints and business logic to an expanded graph database schema.

Highlights

• Collection Management: Introduced functionality to create and manage collections of links, including 'smart' collections based on queries.
• Related Links Feature: Added an API endpoint and underlying logic to retrieve links related to a given link, leveraging domain and tag relationships.
• Database Schema Expansion: Updated the ArcadeDB schema with new vertex types for 'Collection', 'Domain', and 'Tag', and new edge types to represent relationships between links, domains, and collections.
• Architectural Integration: Integrated new web controllers, application services, and persistence adapters to support the new collection and related links features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for d4ce047.

🟢 All jobs passed!

But CI Insights is watching 👀

[gemini-code-assist]

Code Review

This pull request adds collection management and related links functionality, which is a great enhancement. The code is generally well-structured and follows the existing hexagonal architecture. However, I've identified a few issues that need attention. There are several duplicate imports and some code duplication in the Application class. The new controllers contain redundant authentication checks that should be removed. Most importantly, there is a critical bug in the SQL query for fetching related links that will cause it to fail, and a high-severity issue with using an incorrect permission for creating collections. I've provided detailed comments and suggestions for each of these points.

[gemini-code-assist]

This block of initialization logic is duplicated in the start(int port) method (lines 292-300). This extends an existing code duplication issue in the Application class. To improve maintainability and reduce redundancy, consider refactoring the entire dependency injection setup into a private helper method that can be called from both main and start.

[gemini-code-assist]

This userId == null check is redundant. The RequireAuthentication handler is configured for this endpoint in WebBuilder, and it already ensures that an authenticated user exists. If userId were null, the RequireAuthentication handler would have already thrown an AuthenticationException, preventing this code from being reached. Removing this check will make the code cleaner and align better with the framework's security mechanisms.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for d095fb41	✅ 50.74%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (d095fb4)	Report Missing	Report Missing	Report Missing
Head commit (d4ce047)	2106	1185	56.27%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#443)	814	413	50.74%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩