[Mocha] Merge 16.7.3 into the NATS transport

.github/workflows/ci.yml

@@ -167,7 +167,9 @@ jobs:
         run: npm ci
         working-directory: website
 
-      - name: Install Playwright Chromium
+      # rehype-mermaid renders inline SVG with Chromium during the app build.
+      # Visual tests use their own pinned Docker browser, not this installation.
+      - name: Install Chromium for Mermaid Build
         run: npx playwright install --with-deps chromium
         working-directory: website
 
@@ -187,10 +189,25 @@ jobs:
         run: npm run build
         working-directory: website
 
+      - name: Visual Runner Contract Tests
+        run: node --test scripts/visual-tests-docker.test.mjs
+        working-directory: website
+
       - name: Visual Regression Tests
         run: npm run test:visual
         working-directory: website
 
+      - name: Clean Up Visual Test Containers
+        if: ${{ always() }}
+        shell: bash
+        run: |
+          workspace="$(pwd -P)"
+          run="${GITHUB_RUN_ID}-${GITHUB_RUN_ATTEMPT}-${GITHUB_JOB}"
+          docker ps --all --quiet --filter "label=website-visual-workspace=$workspace" --filter "label=website-visual-run=$run" |
+            xargs --no-run-if-empty docker rm --force
+          docker volume ls --quiet --filter "label=website-visual-workspace=$workspace" --filter "label=website-visual-run=$run" |
+            xargs --no-run-if-empty docker volume rm
+
       - name: Upload Playwright Report
         if: ${{ !cancelled() }}
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1

AGENTS.md

@@ -6,6 +6,10 @@ This file provides guidance to coding agents when working with this repository.
 
 - Do not add `Co-authored-by` trailers or other co-author attribution for agents.
 
+## Commit Messages
+
+- Wrap every `@`-prefixed token in backticks, so GitHub does not turn it into a mention. This covers directive names, package scopes, and user handles: ``Fix pruning of list-wrapped `@require` input types``.
+
 ## Pull Requests
 
 - Start a bug fix PR title with `Fix`: `Fix the gateway ignoring subgraph timeouts`. The title becomes the squash commit subject and the release note entry.

dictionary.txt

@@ -13,8 +13,6 @@ anthropics
 Antiforgery
 apphost
 appsettings
-ASPDEPR004
-ASPDEPR008
 aspnet
 aspnetcore
 Astromech

src/All.slnx

@@ -429,6 +429,7 @@
     <Project Path="Mocha/test/Mocha.Transport.Nats.Tests/Mocha.Transport.Nats.Tests.csproj" />
     <Project Path="Mocha/test/Mocha.Transport.Postgres.Tests/Mocha.Transport.Postgres.Tests.csproj" />
     <Project Path="Mocha/test/Mocha.Transport.RabbitMQ.Tests/Mocha.Transport.RabbitMQ.Tests.csproj" />
+    <Project Path="Mocha/test/Mocha.Transport.RabbitMQ3.Tests/Mocha.Transport.RabbitMQ3.Tests.csproj" />
   </Folder>
   <Folder Name="/Nitro/" />
   <Folder Name="/Nitro/CommandLine/" />

src/CookieCrumble/src/CookieCrumble.Resources.RabbitMQ/RabbitMQResource.cs

@@ -4,6 +4,11 @@ namespace CookieCrumble.Resources;
 
 public class RabbitMQResource : ContainerResource<RabbitMqContainer>
 {
+    /// <summary>
+    /// Gets the broker image the resource runs. Defaults to <c>rabbitmq:4.3</c>.
+    /// </summary>
+    public string Image { get; init; } = "rabbitmq:4.3";
+
     public string ConnectionString => Container.GetConnectionString();
 
     public string Hostname => Container.Hostname;
@@ -27,7 +32,7 @@ public async Task<string> InvokeCommandAsync(IEnumerable<string> command)
 
     protected override RabbitMqContainer Build()
         => Configure(
-            new RabbitMqBuilder("rabbitmq:3.11")
+            new RabbitMqBuilder(Image)
                 .WithUsername("guest")
                 .WithPassword("guest"))
             .Build();

src/Directory.Build.props

@@ -17,7 +17,7 @@
 
   <PropertyGroup Condition="'$(TreatWarningsAsErrors)' == ''">
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <WarningsNotAsErrors>NU1901;NU1902;NU1903;NU1904;ASPDEPR004;ASPDEPR008</WarningsNotAsErrors>
+    <WarningsNotAsErrors>NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(TreatWarningsAsErrors)' == 'false'">

src/GreenDonut/src/GreenDonut.Data/Cursors/CursorKeySerializerHelper.cs

@@ -97,7 +97,7 @@ public static bool TryFormat(object? key, ICursorKeySerializer serializer, Span<
             return success;
         }
 
-        var start = buffer.IndexOf((byte)':');
+        var start = buffer[..written].IndexOf((byte)':');
         return start == -1 ? success : ReplaceColons(buffer, start, written, out written);
     }
 

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/PagingTotalCountTests.cs

@@ -242,7 +242,7 @@ public async ValueTask DisposeAsync()
 
     private sealed class PagingContext(DbContextOptions<PagingContext> options) : DbContext(options)
     {
-        public DbSet<Item> Items => Set<Item>();
+        public DbSet<Item> Items { get; set; }
     }
 
     private sealed class Item

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/RelativeCursorTests.cs

@@ -875,7 +875,7 @@ protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
             optionsBuilder.UseNpgsql(connectionString);
         }
 
-        public DbSet<Brand> Brands => Set<Brand>();
+        public DbSet<Brand> Brands { get; set; }
     }
 
     public class Brand

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/AnimalContext.cs

@@ -5,10 +5,10 @@ namespace GreenDonut.Data.TestContext;
 
 public class AnimalContext(string connectionString) : DbContext
 {
-    public DbSet<Owner> Owners { get; set; } = null!;
-    public DbSet<Animal> Pets { get; set; } = null!;
-    public DbSet<Dog> Dogs { get; set; } = null!;
-    public DbSet<Cat> Cats { get; set; } = null!;
+    public DbSet<Owner> Owners { get; set; }
+    public DbSet<Animal> Pets { get; set; }
+    public DbSet<Dog> Dogs { get; set; }
+    public DbSet<Cat> Cats { get; set; }
 
     protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
         => optionsBuilder.UseNpgsql(connectionString);

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/CatalogContext.cs

@@ -10,13 +10,13 @@ protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
         optionsBuilder.UseNpgsql(connectionString);
     }
 
-    public DbSet<Product> Products { get; set; } = null!;
+    public DbSet<Product> Products { get; set; }
 
-    public DbSet<ProductType> ProductTypes { get; set; } = null!;
+    public DbSet<ProductType> ProductTypes { get; set; }
 
-    public DbSet<Brand> Brands { get; set; } = null!;
+    public DbSet<Brand> Brands { get; set; }
 
-    public DbSet<Test> Tests { get; set; } = null!;
+    public DbSet<Test> Tests { get; set; }
 
     protected override void OnModelCreating(ModelBuilder builder)
     {

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/FileSystemContext.cs

@@ -4,11 +4,11 @@ namespace GreenDonut.Data.TestContext;
 
 public class FileSystemContext(string connectionString) : DbContext
 {
-    public DbSet<FileSystemEntry> Entries => Set<FileSystemEntry>();
+    public DbSet<FileSystemEntry> Entries { get; set; }
 
-    public DbSet<FileSystemDirectory> Directories => Set<FileSystemDirectory>();
+    public DbSet<FileSystemDirectory> Directories { get; set; }
 
-    public DbSet<FileSystemFile> Files => Set<FileSystemFile>();
+    public DbSet<FileSystemFile> Files { get; set; }
 
     protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
     {

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/FooBarContext.cs

@@ -10,9 +10,9 @@ protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
         optionsBuilder.UseNpgsql(connectionString);
     }
 
-    public DbSet<Foo> Foos { get; set; } = null!;
+    public DbSet<Foo> Foos { get; set; }
 
-    public DbSet<Bar> Bars { get; set; } = null!;
+    public DbSet<Bar> Bars { get; set; }
 
     protected override void OnModelCreating(ModelBuilder modelBuilder)
     {

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/NullableTestsContext.cs

@@ -20,9 +20,9 @@ protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
         }
     }
 
-    public DbSet<Record> Records { get; set; } = null!;
+    public DbSet<Record> Records { get; set; }
 
-    public DbSet<Item> Items { get; set; } = null!;
+    public DbSet<Item> Items { get; set; }
 }
 
 public class Record

src/GreenDonut/test/GreenDonut.Data.Tests/Cursors/CursorKeySerializerHelperTests.cs

@@ -109,6 +109,25 @@ public static void TryFormat_StringWithoutColons_FormatsCorrectly()
         Assert.Equal("testvalue", Encoding.UTF8.GetString(buffer[..written]));
     }
 
+    [Fact]
+    public static void TryFormat_Should_IgnoreColon_When_ColonIsBehindWrittenBytes()
+    {
+        // arrange
+        object key = "testvalue";
+        Span<byte> buffer = "xxxxxxxxxxxxxxx:"u8.ToArray();
+
+        // act
+        var success = CursorKeySerializerHelper.TryFormat(
+            key,
+            s_serializer,
+            buffer,
+            out var written);
+
+        // assert
+        Assert.True(success);
+        Assert.Equal(9, written);
+    }
+
     [Fact]
     public static void TryFormat_StringWithColons_EscapesAndFormatsCorrectly()
     {