feature: support v4 jobs API

[rustatian]

Reason for This PR

ref: roadrunner-server/roadrunner#1941

Description of Changes

• Support NackWithOptions method.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

• All commits in this PR are signed (git commit -s).
• The reason for this PR is clearly provided (issue no. or explanation).
• The description of changes is clear and encompassing.
• Any required documentation changes (code and docs) are included in this PR.
• Any user-facing changes are mentioned in CHANGELOG.md.
• All added/changed functionality is tested.

Summary by CodeRabbit

• Chores

  • Updated GitHub Actions workflow to use golangci-lint version v1.59.
  • Updated PHP version to 8.3 and OS to ubuntu-latest in CI configurations.
  • Ignored composer.lock files in all directories.
  • Updated versions of various dependencies in go.mod files.

• Refactor

  • Updated import paths and methods to use new versions of dependencies and added new utility functions.

[coderabbitai]

Walkthrough

The recent updates modernize several configurations, primarily upgrading versions of tools and dependencies. Key changes include updating the GitHub Actions workflows to use newer versions of golangci-lint, PHP, and the operating system. Dependency definitions in go.mod for the roadrunner-server modules are also updated. Additionally, some code and configuration adjustments improve code quality and compatibility with the updated dependencies.

Changes

Files	Change Summary
.github/workflows/linters.yml	Updated golangci-lint version from v1.54 to v1.59.
.github/workflows/linux.yml	Updated PHP version to 8.3 and OS to ubuntu-latest.
.github/workflows/linux_durability.yml	Updated PHP to 8.3, adjusted docker-compose and go test commands, and minor formatting changes.
.gitignore	Added pattern **/composer.lock to ignore composer.lock files.
.golangci.yml	Restructured linter settings and excluded specific directories from linting.
go.mod	Updated github.com/roadrunner-server/api/v4 from v4.12.0 to v4.13.0.
natsjobs/driver.go, plugin.go	Updated import path for jobs from v3 to v4.
natsjobs/item.go	Added imports "maps" and .../jobs/v4, added method NackWithOptions, modified Requeue method.
natsjobs/listener.go	Added term and nakWithDelay functions in Options struct within item.
tests/go.mod	Updated versions for multiple roadrunner-server packages such as api, config, jobs, etc.

Poem

🐇✨
Code’s tapestry, unwound and redone,
With tools renewed, the work's begun.
PHP and Go, fresh and bright,
Linting polished, sparkling in the light.
Dependencies grown, like fields in spring,
To these changes, we joyfully cling.
🐇🔧

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

natsjobs/item.go (1)

144-156: Review the implementation of NackWithOptions.

The NackWithOptions method adds significant functionality for handling message failures with options for requeuing or terminating. Ensure that the logic for requeuing (nakWithDelay) and terminating (term) is robust and handles all edge cases, especially in a multi-threaded environment.

Consider adding more robust error handling and logging within this method to ensure that all possible failure modes are accounted for and appropriately logged.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 969df07 and 3d90b0c.

Files ignored due to path filters (4)

• go.sum is excluded by !**/*.sum
• go.work.sum is excluded by !**/*.sum
• tests/go.sum is excluded by !**/*.sum
• tests/php_test_files/composer.lock is excluded by !**/*.lock

Files selected for processing (11)

• .github/workflows/linters.yml (1 hunks)
• .github/workflows/linux.yml (1 hunks)
• .github/workflows/linux_durability.yml (2 hunks)
• .gitignore (1 hunks)
• .golangci.yml (3 hunks)
• go.mod (1 hunks)
• natsjobs/driver.go (1 hunks)
• natsjobs/item.go (3 hunks)
• natsjobs/listener.go (1 hunks)
• plugin.go (1 hunks)
• tests/go.mod (2 hunks)

Files skipped from review due to trivial changes (9)

• .github/workflows/linters.yml
• .github/workflows/linux.yml
• .github/workflows/linux_durability.yml
• .gitignore
• .golangci.yml
• go.mod
• natsjobs/driver.go
• plugin.go
• tests/go.mod

Additional comments not posted (1)

natsjobs/listener.go (1)

92-93: Ensure proper integration of term and nakWithDelay handling functions.

The addition of term and nakWithDelay to the Options struct within the listenerStart method enhances the message handling capabilities. Ensure that these functions are correctly integrated and tested, especially since they involve error handling and state management.