Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove otel experimental flag #133

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Apr 12, 2024

Reason for This PR

  • experiment is done.

Description of Changes

  • Remove the experimental flag for the otel handler.
  • Update proto in the CI to v26.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Refactor
    • Updated versions of linter tools and protoc in the GitHub Actions workflows to enhance code quality checks.
    • Adjusted linter settings and simplified the codebase by removing experimental feature flags in plugin.go and server.go.

@rustatian rustatian added the enhancement New feature or request label Apr 12, 2024
@rustatian rustatian requested a review from wolfy-j April 12, 2024 08:07
@rustatian rustatian self-assigned this Apr 12, 2024
Copy link

coderabbitai bot commented Apr 12, 2024

Walkthrough

The updates involve enhancements to the project's development tools and configurations. Versions of both GitHub Actions and golangci-lint are upgraded, likely improving performance and compliance. Changes in configuration files streamline linting processes, and modifications in Go source files suggest a move away from experimental features in the codebase, focusing on stability and standard functionality.

Changes

Files Summary of Changes
.github/.../linters.yml Updated golangci-lint-action and golangci-lint versions.
.github/.../linux.yml Updated protoc version from '23.x' to '26.x'.
.golangci.yml Streamlined linting settings and removed specific linter configurations.
plugin.go, server.go Removed usage of an experimental feature flag in the code.

Poem

🐰✨
In the burrow of code, under moonlit screens,
Changes hop through, fresh and keen.
Tools polished bright, and linters keen,
No more flags experimental to be seen.
Oh, how tidy our codebase gleams!
🌟📜


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9b8637a and ddf56d8.
Files ignored due to path filters (1)
  • go.work.sum is excluded by !**/*.sum
Files selected for processing (5)
  • .github/workflows/linters.yml (1 hunks)
  • .github/workflows/linux.yml (1 hunks)
  • .golangci.yml (3 hunks)
  • plugin.go (2 hunks)
  • server.go (1 hunks)
Additional comments not posted (6)
.github/workflows/linters.yml (2)

19-19: Ensure compatibility of the updated GitHub Action golangci/[email protected] with the project's CI pipeline.


21-21: Review the release notes for golangci-lint v1.57 to ensure there are no changes that might negatively impact the project.

.golangci.yml (1)

70-72: Excluding .github and .git directories from linter checks is a good practice to avoid unnecessary linting of non-source code directories.

.github/workflows/linux.yml (1)

71-71: Verify compatibility of the updated protoc version '26.x' with the project's protobuf files to ensure no breaking changes are introduced.

server.go (1)

50-50: Removal of the conditional check for the experimental flag simplifies the server setup process and aligns with the PR's objectives.

plugin.go (1)

Line range hint 19-19: Removal of the experimental field from the Plugin struct indicates the feature's stability and aligns with the PR's objectives.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustatian rustatian merged commit e3c7d4f into master Apr 12, 2024
6 checks passed
@rustatian rustatian deleted the chore/remove_otel_experimental branch April 12, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant