-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: incorrect error usage in the logs #175
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
WalkthroughThe recent updates enhance error logging in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.work.sum
is excluded by!**/*.sum
Files selected for processing (2)
- poller.go (1 hunks)
- stop.go (1 hunks)
Additional context used
golangci-lint
poller.go
8-8: undefined: Endure (typecheck)
24-24: undefined: Endure (typecheck)
9-9: undefined: result (typecheck)
29-29: undefined: Result (typecheck)
stop.go
15-15: undefined: Endure (typecheck)
35-35: undefined: Service (typecheck)
41-41: undefined: StopMethodName (typecheck)
Additional comments not posted (2)
poller.go (1)
15-15
: LGTM! The use ofslog.Any
for error logging enhances the clarity and specificity of the log messages.stop.go (1)
56-56
: LGTM! The updated error logging usingslog.Any
is consistent with the PR objectives and improves the clarity of the log messages.
Reason for This PR
Description of Changes
slog.Any
for the errors.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit