check to ensure that our parent is an element and not a fragment

rniemeyer · Apr 11, 2014 · b63ae4b · b63ae4b
1 parent b140959
commit b63ae4b
Show file tree

Hide file tree

Showing 9 changed files with 105 additions and 103 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
     "name": "knockout-delegatedEvents",
-    "version": "0.3.0",
+    "version": "0.3.1",
     "main": "build/knockout-delegatedEvents.min.js",
     "ignore": [
         "examples",

diff --git a/build/knockout-delegatedEvents.js b/build/knockout-delegatedEvents.js
@@ -1,4 +1,4 @@
-// knockout-delegatedEvents 0.3.0 | (c) 2014 Ryan Niemeyer |  http://www.opensource.org/licenses/mit-license
+// knockout-delegatedEvents 0.3.1 | (c) 2014 Ryan Niemeyer |  http://www.opensource.org/licenses/mit-license
 ;(function(factory) {
     //CommonJS
     if (typeof require === "function" && typeof exports === "object" && typeof module === "object") {
@@ -21,7 +21,7 @@
 
             //loop until we either find an action, run out of elements, or hit the root element that has our delegated handler
             while (!method && el) {
-                method = el.getAttribute(attr) || ko.utils.domData.get(el, key);
+                method = el.nodeType === 1 && (el.getAttribute(attr) || ko.utils.domData.get(el, key));
                 if (!method) {
                     el = el !== root ? el.parentNode : null;
                 }

diff --git a/build/knockout-delegatedEvents.min.js b/build/knockout-delegatedEvents.min.js
diff --git a/examples/example.html b/examples/example.html
@@ -37,7 +37,7 @@
     </div>
 
 
-    <script src="../ext/knockout-3.0.0.js"></script>
+    <script src="../ext/knockout-3.1.0.js"></script>
     <script src="../src/knockout-delegatedEvents.js"></script>
     <script>
         var Item = function(id, name, price, description) {

diff --git a/ext/knockout-3.0.0.js b/ext/knockout-3.0.0.js
diff --git a/ext/knockout-3.1.0.js b/ext/knockout-3.1.0.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "knockout-delegatedEvents",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "devDependencies": {
     "grunt": "~0.4.1",
     "grunt-contrib-uglify": "0.x.x",

diff --git a/spec/runner.html b/spec/runner.html
@@ -8,7 +8,7 @@
     <script type="text/javascript" src="lib/boot.js"></script>
 
     <!-- dependencies -->
-    <script src="../ext/knockout-3.0.0.js" type="text/javascript"></script>
+    <script src="../ext/knockout-3.1.0.js" type="text/javascript"></script>
 
     <!-- source files -->
     <script src="../src/knockout-delegatedEvents.js" type="text/javascript"></script>

diff --git a/src/knockout-delegatedEvents.js b/src/knockout-delegatedEvents.js
@@ -20,7 +20,7 @@
 
             //loop until we either find an action, run out of elements, or hit the root element that has our delegated handler
             while (!method && el) {
-                method = el.getAttribute(attr) || ko.utils.domData.get(el, key);
+                method = el.nodeType === 1 && (el.getAttribute(attr) || ko.utils.domData.get(el, key));
                 if (!method) {
                     el = el !== root ? el.parentNode : null;
                 }