fix(method): throws exception on invalid method

Instead, default to GET. closes #62
rnicholus · May 16, 2015 · 4086609 · 4086609
1 parent 52f5959
commit 4086609
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 12 deletions.
diff --git a/ajax-form.js b/ajax-form.js
@@ -466,9 +466,8 @@
                     // Need to look into this further.
                     ajaxForm.acceptableMethod = getValidMethod(ajaxForm.getAttribute('method'));
 
-                    if (!ajaxForm.acceptableMethod) {
-                        throw new Error('Invalid method!');
-                    }
+                    // default method is GET
+                    ajaxForm.acceptableMethod = ajaxForm.acceptableMethod || 'GET';
 
                     watchForInvalidFields(ajaxForm);
                     interceptSubmit(ajaxForm);

diff --git a/demo.html b/demo.html
@@ -56,7 +56,7 @@ <h1><code>ajax-form</code> in action:</h1>
         <h1 id="pleaseWait" class="hidden">Sending your data...</h1>
 
         <div id="content">
-            <form is="ajax-form" action="test" method="post">
+            <form is="ajax-form" action="test" method="post" enctype="multipart/form-data">
                 <div>
                     <label>Full Name: <input type="text" name="name" required></label>
                 </div>
@@ -69,10 +69,14 @@ <h1 id="pleaseWait" class="hidden">Sending your data...</h1>
                     <label>Favorite color: <input type="text" name="color"></label>
                 </div>
 
+                <input type="file" name="file">
+                <custom-checkbox role="checkbox" name="customcheckboxname" value="customcheckboxvalue">cust check</custom-checkbox>
+
                 <div>
                     <b>Receive periodic email updates from us?</b>
                     <input type="radio" name="emailCommunication" value="yes" checked>yes
                     <input type="radio" name="emailCommunication" value="no">no
+                    <input type="checkbox" name="testcheck" value="testval">testcheck
                 </div>
 
                 <input type="submit">
@@ -143,14 +147,14 @@ <h3>Validation</h3>
         // with the form submit.  This is needed since the demo doesn't have
         // a server to handle these requests.
         (function() {
-            sinon.FakeXMLHttpRequest.useFilters = true;
-            sinon.FakeXMLHttpRequest.addFilter(function (method, url) {
-                return !(/test/).test(url);
-            });
-            var server = sinon.fakeServer.create();
-            server.respondWith([200, {}, '']);
-            server.autoRespond = true;
-            server.autoRespondAfter = 5000;
+//            sinon.FakeXMLHttpRequest.useFilters = true;
+//            sinon.FakeXMLHttpRequest.addFilter(function (method, url) {
+//                return !(/test/).test(url);
+//            });
+//            var server = sinon.fakeServer.create();
+//            server.respondWith([200, {}, '']);
+//            server.autoRespond = true;
+//            server.autoRespondAfter = 5000;
         }());
     </script>