Feature: Percentage discount on lists #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add percent discount to equipment lists. The percentage discount is applied to each row to get a value in kronor, which is added to the row-specific discount.
I am marking this as a draft since I want feedback and ideas on how to communicate these discounts clearly to the user and to the customer, as these now are quite a few factors affecting the price (base price, number of days, row discount and list discount). For now, I have only done the bare minimum in terms of communicating the discount:
In the following screenshots the top row have a manual discount of the full price (i.e. I used the "Sätt rabatt till 100%" feature), the second row have a manual price of 0 (i.e. I used the "Sätt anpassat pris till 0" feature), the third row have manual discount of 32 kr ex moms (40 kr inc moms), and finally the last row are a "normal row" with a simple price and no manual discount applied.
In particular, I want feedback on what to show in the discount information popover, as it currently only shows the total. We could split the discount into percentage/list and manual/row, but it was har to label these values in a clear and concise way. To further complicate things, the maximum discount is the full price (since rows cannot have a negative sum) so if the sum of the discounts is to large we need to reduce it which also might be hard to communicate in a clear way.