Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Percentage discount on lists #66

Merged
merged 7 commits into from
Oct 26, 2024

Conversation

gingemarsson
Copy link
Contributor

Add percent discount to equipment lists. The percentage discount is applied to each row to get a value in kronor, which is added to the row-specific discount.

I am marking this as a draft since I want feedback and ideas on how to communicate these discounts clearly to the user and to the customer, as these now are quite a few factors affecting the price (base price, number of days, row discount and list discount). For now, I have only done the bare minimum in terms of communicating the discount:

  • Showing the percentage discount with the list header (both document and stage)
  • Include de percentage discount in the shown discount (both document and stage)
  • In the Advanced Editing view, show the percentage discount below the row discount field.

In the following screenshots the top row have a manual discount of the full price (i.e. I used the "Sätt rabatt till 100%" feature), the second row have a manual price of 0 (i.e. I used the "Sätt anpassat pris till 0" feature), the third row have manual discount of 32 kr ex moms (40 kr inc moms), and finally the last row are a "normal row" with a simple price and no manual discount applied.

image
image
image

In particular, I want feedback on what to show in the discount information popover, as it currently only shows the total. We could split the discount into percentage/list and manual/row, but it was har to label these values in a clear and concise way. To further complicate things, the maximum discount is the full price (since rows cannot have a negative sum) so if the sum of the discounts is to large we need to reduce it which also might be hard to communicate in a clear way.
image

@gingemarsson gingemarsson linked an issue Aug 31, 2024 that may be closed by this pull request
@m4reko
Copy link
Contributor

m4reko commented Oct 10, 2024

Wouldn't it be reasonable to always apply the list discount after the entry discount? That would somewhat solve the problem of the two discounts adding up to more than the price. The behavior would be very similair to how it works today for entry discounts only adding another percentage discount after it which of course never go below 0.

@gingemarsson gingemarsson marked this pull request as ready for review October 26, 2024 19:30
@m4reko m4reko merged commit 6e0f8a4 into main Oct 26, 2024
3 checks passed
@m4reko m4reko deleted the feature/percentage-discount-on-lists branch October 26, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lägg in procentuell rabatt per utrustningslista
2 participants