This repository has been archived by the owner on Mar 17, 2022. It is now read-only.
Update to support latest Android Studio #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently that is the minimum supported version by build tools.
Version and SDK information is overriden by build.gradle files, so it shouldn't be here anymore.
Android Studio throws build error that Google Play requires apps to use at least targat sdk 26, so let's use latest. One problem is that we need to grant runtime permissions to access storage before using tests.
I couldn't make GrantPermissionRule to work for some reason. https://developer.android.com/reference/android/support/test/rule/GrantPermissionRule
Closed
rmtheis
reviewed
Jan 12, 2019
| compileSdkVersion 27 | ||
| buildToolsVersion '27.0.3' | ||
| compileSdkVersion 28 | ||
| buildToolsVersion '28.0.3' |
There was a problem hiding this comment.
I think this line and the other buildToolsVersion lines can be removed altogether with 28.
rmtheis
reviewed
Jan 12, 2019
| @@ -9,5 +9,5 @@ endif | |||
| # Specify the hash namespace that we're using, based on the APP_STL we're using. | |||
| APP_CFLAGS += -Werror -DHASH_NAMESPACE=__gnu_cxx -Wno-error=deprecated-register | |||
| APP_PLATFORM := android-16 | |||
| APP_STL := gnustl_static | |||
| APP_STL := c++_static | |||
There was a problem hiding this comment.
This file is kind of a red herring and is ignored by this project, so the change on this line can be reverted. This file exists in the Tesseract code base and seems to be used for an internal build at Google.
|
Nice. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update target SDK to API 28, minimum to API 16, update Gradle, libraries, etc. to have it working correctly in latest stable Android Studio (3.2.1).