Implements BulkWriter.transferAndEquip. #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NFT to transfer can be equipped, nested or free. The destination must be an NFT. The NFT can be equipped into the destination. If destination slot is occupied, it will be unequipped. All these operations happen under a single transactions, given the right approvals.
Implements BulkWriter.transferAndEquip.
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Yuripetusko
reviewed
Apr 19, 2024
|
|
||
| if (equipData.assetId == 0) return; | ||
|
|
||
| _unequipSlotIfNecessary( |
There was a problem hiding this comment.
wondering if there's any benefit in re-using replaceEquipement function from this contract here instead?
There was a problem hiding this comment.
Sound great, will give it a try.
Yuripetusko
approved these changes
Apr 19, 2024
This saves about 40% of gas since accept operation is not needed, and pending children array is not used. It also saves 4.5% of contract size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The NFT to transfer can be equipped, nested or free. The destination must be an NFT.
The NFT can be equipped into the destination.
If destination slot is occupied, it will be unequipped.
All these operations happen under a single transactions, given the right approvals.
Checklist