Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds several utilities to catalog and catalog factory. #261

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

steven2308
Copy link
Member

@steven2308 steven2308 commented Feb 29, 2024

Description

Describe the additions/improvements this PR contains.

Checklist

  • Verified code additions
  • Updated NatSpec comments (if applicable)
  • Regenerated docs
  • Ran prettier
  • Added tests to fully cover the changes

PR-Codex overview

This PR enhances RMRK catalog contracts and deployment scripts, adds extended catalog interfaces, updates test interfaces, and refactors catalog implementation.

Detailed summary

  • Updated visibility of variables in RMRKCatalogImpl
  • Added IRMRKCatalogExtended interface
  • Implemented RMRKCatalogFactory contract for deploying catalogs
  • Added deployment scripts for catalog factory and render utils
  • Updated gas price in Hardhat config
  • Updated network URLs in Hardhat config
  • Updated test interfaces and exported constants

The following files were skipped due to too many changes: contracts/implementations/RMRKCatalogImpl.sol, docs/implementations/catalog/RMRKCatalogFactory.md, test/implementations/catalogFactory.ts, docs/implementations/RMRKCatalogImpl.md, test/implementations/catalog.ts, docs/implementations/catalog/IRMRKCatalogExtended.md

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

openzeppelin-code bot commented Feb 29, 2024

Adds several utilities to catalog and catalog factory.

Generated at commit: aa3108177eda990ce3594926c842712a82e84418

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
0
0
4
26
31
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Member

@Yuripetusko Yuripetusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven2308 steven2308 merged commit c5bad77 into dev Mar 1, 2024
4 checks passed
@steven2308 steven2308 deleted the better-catalog branch March 1, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants