bug fix: extensions can register more extensions via apply method #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmosolgo#5054 introduced a regression where an extension registered eagerly can no longer register another extension in its `apply` method. I fix the bug here by restoring the previous `@call_after_define` logic.
ElvinEfendi
force-pushed
the
elvin/fix-extension-instantiation
branch
from
8f4e049
to
ca493a0
Compare
|
Sorry for the trouble and thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5054 introduced a regression where an extension registered eagerly (using the kwarg) can no longer register another extension in its
applymethod. I fix the bug here by restoring the previous@call_after_definelogic.