Add a parameter flag to clean up artifacts after build #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good to me. Can you just update the tests to exercise this behavior? |
Contributor
Author
|
I added the parameter to the tests |
Owner
|
I've run the tests locally. Not sure why actions aren't triggering. Will merge and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The artifacts that are generated by the scripts persist in the source tree. This PR adds a new parameter to remove the generated artifacts after build with the
finalizehook.This is probably a very minor issue, but I like keeping the source tree clean.
Summary
With the finalize hook, we can cleanup the generated artefacts in the build directory.
I also bumped the version. @rmorshea not sure what your version bump policy is, feel free to adjust the version as you like.