Add format parameter to url_from_file_path function and accept / in any Windows path
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs.microsoft.com -> learn.microsoft.com
* is_Windows_drive -> is_windows_drive * is_normalized_Windows_drive -> is_normalized_windows_drive * starts_with_Windows_drive => starts_with_windows_drive * starts_with_Windows_drive_absolute_path -> starts_with_windows_drive_absolute_path
Also allow lower case "unc" in "\\?\unc\host\path".
This parameter specifies the format of the given file path.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 99.72% 99.73%
=======================================
Files 15 15
Lines 2217 2223 +6
=======================================
+ Hits 2211 2217 +6
Misses 6 6
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
formatparameter specifies the format of the given file path - POSIX or Windows. It can have any of the following values:upa::file_path_format::detect- detect file path format from first character:/- POSIX, otherwise - Windowsupa::file_path_format::posix- POSIX file path formatupa::file_path_format::windows- Windows file path formatupa::file_path_format::native- the file path format corresponds to the OS on which the code was compiled