-
Notifications
You must be signed in to change notification settings - Fork 0
Security hardening: MarketPulse validation, safer JSON IPC, git-only deps #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2e7eb83
bd init: initialize beads issue tracking
rmems b2bd310
Harden MarketPulse validation, safer JSON IPC, git-only LN deps
rmems a1e8709
Add GitHub Actions CI (Rust + Julia CPU)
rmems 3ac6f95
ci: rename rust-cache shared-key (Aikido false positive)
rmems 414436a
Address PR review: wire validation, IPC isolation, hooks
rmems 78e9fdd
fix: address 3 security/quality issues from PR review
cubic-dev-ai[bot] f28e39f
ci: Julia 1.12 matrix and latest stable Rust toolchain
rmems 4648290
fix: PR review hardening — IPC ownership, helm skip, Julia 1.12
rmems b43ebb1
fix: address latest CodeRabbit/Codex review threads
rmems 8d2b336
fix: pin Rust 1.97.1 CI, CLAUDE paths, require dep revs
rmems f27ca03
fix: correct rev-pin assertions in test_integration
rmems 8f4d8f5
fix: evaluate and apply Codex/cubic review findings
rmems 04cb7ec
fix: evaluate latest Codex/CodeRabbit/cubic review
rmems e2262de
fix: evaluate Codex/cubic review — IPC lock, relevance sum, CI
rmems be8942d
fix: evaluate latest review — flock IPC ownership, tests
rmems 8ea80ec
fix: evaluate review — stable flock inode, portable lock open, full-S…
rmems File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| # Dolt database (managed by Dolt, not git) | ||
| dolt/ | ||
| embeddeddolt/ | ||
|
|
||
| # Runtime files | ||
| bd.sock | ||
| bd.sock.startlock | ||
| sync-state.json | ||
| last-touched | ||
| .exclusive-lock | ||
|
|
||
| # Daemon runtime (lock, log, pid) | ||
| daemon.* | ||
|
|
||
| # Push state (runtime, per-machine) | ||
| push-state.json | ||
|
|
||
| # Lock files (various runtime locks) | ||
| *.lock | ||
|
|
||
| # Credential key (encryption key for federation peer auth — never commit) | ||
| .beads-credential-key | ||
|
|
||
| # Local version tracking (prevents upgrade notification spam after git ops) | ||
| .local_version | ||
|
|
||
| # Worktree redirect file (contains relative path to main repo's .beads/) | ||
| # Must not be committed as paths would be wrong in other clones | ||
| redirect | ||
|
|
||
| # Sync state (local-only, per-machine) | ||
| # These files are machine-specific and should not be shared across clones | ||
| .sync.lock | ||
| export-state/ | ||
| export-state.json | ||
|
|
||
| # Ephemeral store (SQLite - wisps/molecules, intentionally not versioned) | ||
| ephemeral.sqlite3 | ||
| ephemeral.sqlite3-journal | ||
| ephemeral.sqlite3-wal | ||
| ephemeral.sqlite3-shm | ||
|
|
||
| # Dolt server management (auto-started by bd) | ||
| dolt-server.pid | ||
| dolt-server.log | ||
| dolt-server.lock | ||
| dolt-server.port | ||
| dolt-server.activity | ||
|
|
||
| # Corrupt backup directories (created by bd doctor --fix recovery) | ||
| *.corrupt.backup/ | ||
|
|
||
| # Backup data (auto-exported JSONL, local-only) | ||
| backup/ | ||
|
|
||
| # Per-project environment file (Dolt connection config, GH#2520) | ||
| .env | ||
|
|
||
| # Legacy files (from pre-Dolt versions) | ||
| *.db | ||
| *.db?* | ||
| *.db-journal | ||
| *.db-wal | ||
| *.db-shm | ||
| db.sqlite | ||
| bd.db | ||
| # NOTE: Do NOT add negation patterns here. | ||
| # They would override fork protection in .git/info/exclude. | ||
| # Config files (metadata.json, config.yaml) are tracked by git by default | ||
| # since no pattern above ignores them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| # Beads - AI-Native Issue Tracking | ||
|
|
||
| Welcome to Beads! This repository uses **Beads** for issue tracking - a modern, AI-native tool designed to live directly in your codebase alongside your code. | ||
|
|
||
| ## What is Beads? | ||
|
|
||
| Beads is issue tracking that lives in your repo, making it perfect for AI coding agents and developers who want their issues close to their code. No web UI required - everything works through the CLI and integrates seamlessly with git. | ||
|
|
||
| **Learn more:** [github.com/steveyegge/beads](https://github.com/steveyegge/beads) | ||
|
|
||
| ## Quick Start | ||
|
|
||
| ### Essential Commands | ||
|
|
||
| ```bash | ||
| # Create new issues | ||
| bd create "Add user authentication" | ||
|
|
||
| # View all issues | ||
| bd list | ||
|
|
||
| # View issue details | ||
| bd show <issue-id> | ||
|
|
||
| # Update issue status | ||
| bd update <issue-id> --claim | ||
| bd update <issue-id> --status done | ||
|
|
||
| # Sync with Dolt remote | ||
| bd dolt push | ||
| ``` | ||
|
|
||
| ### Working with Issues | ||
|
|
||
| Issues in Beads are: | ||
| - **Git-native**: Stored in Dolt database with version control and branching | ||
| - **AI-friendly**: CLI-first design works perfectly with AI coding agents | ||
| - **Branch-aware**: Issues can follow your branch workflow | ||
| - **Always in sync**: Auto-syncs with your commits | ||
|
|
||
| ## Why Beads? | ||
|
|
||
| ✨ **AI-Native Design** | ||
| - Built specifically for AI-assisted development workflows | ||
| - CLI-first interface works seamlessly with AI coding agents | ||
| - No context switching to web UIs | ||
|
|
||
| 🚀 **Developer Focused** | ||
| - Issues live in your repo, right next to your code | ||
| - Works offline, syncs when you push | ||
| - Fast, lightweight, and stays out of your way | ||
|
|
||
| 🔧 **Git Integration** | ||
| - Automatic sync with git commits | ||
| - Branch-aware issue tracking | ||
| - Dolt-native three-way merge resolution | ||
|
|
||
| ## Get Started with Beads | ||
|
|
||
| Try Beads in your own projects: | ||
|
|
||
| ```bash | ||
| # Install Beads | ||
| curl -sSL https://raw.githubusercontent.com/steveyegge/beads/main/scripts/install.sh | bash | ||
|
rmems marked this conversation as resolved.
rmems marked this conversation as resolved.
|
||
|
|
||
| # Initialize in your repo | ||
| bd init | ||
|
|
||
| # Create your first issue | ||
| bd create "Try out Beads" | ||
| ``` | ||
|
|
||
| ## Learn More | ||
|
|
||
| - **Documentation**: [github.com/steveyegge/beads/docs](https://github.com/steveyegge/beads/tree/main/docs) | ||
| - **Quick Start Guide**: Run `bd quickstart` | ||
| - **Examples**: [github.com/steveyegge/beads/examples](https://github.com/steveyegge/beads/tree/main/examples) | ||
|
|
||
| --- | ||
|
|
||
| *Beads: Issue tracking that moves at the speed of thought* ⚡ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # Beads Configuration File | ||
| # This file configures default behavior for all bd commands in this repository | ||
| # All settings can also be set via environment variables (BD_* prefix) | ||
| # or overridden with command-line flags | ||
|
|
||
| # Issue prefix for this repository (used by bd init) | ||
| # If not set, bd init will auto-detect from directory name | ||
| # Example: issue-prefix: "myproject" creates issues like "myproject-1", "myproject-2", etc. | ||
| # issue-prefix: "" | ||
|
|
||
| # Use no-db mode: JSONL-only, no Dolt database | ||
| # When true, bd will use .beads/issues.jsonl as the source of truth | ||
| # no-db: false | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| # Enable JSON output by default | ||
| # json: false | ||
|
|
||
| # Feedback title formatting for mutating commands (create/update/close/dep/edit) | ||
| # 0 = hide titles, N > 0 = truncate to N characters | ||
| # output: | ||
| # title-length: 255 | ||
|
|
||
| # Default actor for audit trails (overridden by BEADS_ACTOR or --actor) | ||
| # actor: "" | ||
|
|
||
| # Export events (audit trail) to .beads/events.jsonl on each flush/sync | ||
| # When enabled, new events are appended incrementally using a high-water mark. | ||
| # Use 'bd export --events' to trigger manually regardless of this setting. | ||
| # events-export: false | ||
|
|
||
| # Multi-repo configuration (experimental - bd-307) | ||
| # Allows hydrating from multiple repositories and routing writes to the correct database | ||
| # repos: | ||
| # primary: "." # Primary repo (where this database lives) | ||
| # additional: # Additional repos to hydrate from (read-only) | ||
| # - ~/beads-planning # Personal planning repo | ||
| # - ~/work-planning # Work planning repo | ||
|
|
||
| # JSONL backup (periodic export for off-machine recovery) | ||
| # Auto-enabled when a git remote exists. Override explicitly: | ||
| # backup: | ||
| # enabled: false # Disable auto-backup entirely | ||
| # interval: 15m # Minimum time between auto-exports | ||
| # git-push: false # Disable git push (export locally only) | ||
| # git-repo: "" # Separate git repo for backups (default: project repo) | ||
|
|
||
| # Integration settings (access with 'bd config get/set') | ||
| # Non-secret keys (stored in the database): | ||
| # - jira.url, jira.project | ||
| # - linear.team_id | ||
| # - github.org, github.repo | ||
| # | ||
| # Secret keys (stored in this file but prefer env vars to avoid git exposure): | ||
| # - linear.api_key → use LINEAR_API_KEY env var instead | ||
| # - github.token → use GITHUB_TOKEN env var instead | ||
|
rmems marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| #!/bin/sh | ||
| # Git LFS (optional): skip when not installed; propagate LFS failure when present. | ||
| if command -v git-lfs >/dev/null 2>&1; then | ||
| git lfs post-checkout "$@" | ||
| _lfs_exit=$? | ||
| [ "$_lfs_exit" -eq 0 ] || exit "$_lfs_exit" | ||
| fi | ||
|
|
||
| # --- BEGIN BEADS INTEGRATION v1.0.4 --- | ||
| # This section is managed by beads. Do not remove these markers. | ||
| if command -v bd >/dev/null 2>&1; then | ||
| export BD_GIT_HOOK=1 | ||
| _bd_timeout=${BEADS_HOOK_TIMEOUT:-300} | ||
| if command -v timeout >/dev/null 2>&1; then | ||
| timeout "$_bd_timeout" bd hooks run post-checkout "$@" | ||
| _bd_exit=$? | ||
| if [ $_bd_exit -eq 124 ]; then | ||
| echo >&2 "beads: hook 'post-checkout' timed out after ${_bd_timeout}s — continuing without beads" | ||
| _bd_exit=0 | ||
| fi | ||
| else | ||
| bd hooks run post-checkout "$@" | ||
|
rmems marked this conversation as resolved.
rmems marked this conversation as resolved.
|
||
| _bd_exit=$? | ||
| fi | ||
| if [ $_bd_exit -eq 3 ]; then | ||
| echo >&2 "beads: database not initialized — skipping hook 'post-checkout'" | ||
| _bd_exit=0 | ||
| fi | ||
| if [ $_bd_exit -ne 0 ]; then exit $_bd_exit; fi | ||
| fi | ||
| # --- END BEADS INTEGRATION v1.0.4 --- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/bin/sh | ||
| command -v git-lfs >/dev/null 2>&1 || { printf >&2 "\n%s\n\n" "This repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting the 'post-commit' file in the hooks directory (set by 'core.hookspath'; usually '.git/hooks')."; exit 2; } | ||
| git lfs post-commit "$@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| #!/bin/sh | ||
| # Git LFS (optional): skip when not installed; propagate LFS failure when present. | ||
| if command -v git-lfs >/dev/null 2>&1; then | ||
| git lfs post-merge "$@" | ||
| _lfs_exit=$? | ||
| [ "$_lfs_exit" -eq 0 ] || exit "$_lfs_exit" | ||
|
cubic-dev-ai[bot] marked this conversation as resolved.
|
||
| fi | ||
|
|
||
| # --- BEGIN BEADS INTEGRATION v1.0.4 --- | ||
| # This section is managed by beads. Do not remove these markers. | ||
| if command -v bd >/dev/null 2>&1; then | ||
| export BD_GIT_HOOK=1 | ||
| _bd_timeout=${BEADS_HOOK_TIMEOUT:-300} | ||
| if command -v timeout >/dev/null 2>&1; then | ||
| timeout "$_bd_timeout" bd hooks run post-merge "$@" | ||
| _bd_exit=$? | ||
| if [ $_bd_exit -eq 124 ]; then | ||
| echo >&2 "beads: hook 'post-merge' timed out after ${_bd_timeout}s — continuing without beads" | ||
| _bd_exit=0 | ||
| fi | ||
| else | ||
| bd hooks run post-merge "$@" | ||
| _bd_exit=$? | ||
| fi | ||
| if [ $_bd_exit -eq 3 ]; then | ||
| echo >&2 "beads: database not initialized — skipping hook 'post-merge'" | ||
| _bd_exit=0 | ||
| fi | ||
| if [ $_bd_exit -ne 0 ]; then exit $_bd_exit; fi | ||
| fi | ||
| # --- END BEADS INTEGRATION v1.0.4 --- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| #!/bin/sh | ||
| # --- Aikido local scanner (optional; resolve via PATH or AIKIDO_LOCAL_SCANNER) --- | ||
| _AIKIDO_SCANNER="${AIKIDO_LOCAL_SCANNER:-}" | ||
| _AIKIDO_EXPLICIT=0 | ||
| if [ -n "$_AIKIDO_SCANNER" ]; then | ||
| _AIKIDO_EXPLICIT=1 | ||
| else | ||
| _AIKIDO_SCANNER="$(command -v aikido-local-scanner 2>/dev/null || true)" | ||
| fi | ||
| if [ -n "$_AIKIDO_SCANNER" ] && [ -x "$_AIKIDO_SCANNER" ]; then | ||
| REPO_ROOT="$(git rev-parse --show-toplevel)" | ||
| "$_AIKIDO_SCANNER" pre-commit-scan "$REPO_ROOT" | ||
| _aikido_exit=$? | ||
| if [ "$_aikido_exit" -ne 0 ]; then | ||
| exit "$_aikido_exit" | ||
| fi | ||
| elif [ "$_AIKIDO_EXPLICIT" -eq 1 ]; then | ||
| # Fail closed when the operator explicitly configured a scanner path. | ||
| echo >&2 "beads/pre-commit: AIKIDO_LOCAL_SCANNER is set but not executable: $_AIKIDO_SCANNER" | ||
| exit 1 | ||
| else | ||
| # Do not block collaborators/CI without a local Aikido install. | ||
| echo >&2 "beads/pre-commit: aikido-local-scanner not found on PATH (set AIKIDO_LOCAL_SCANNER to enforce) — skipping secret scan" | ||
| fi | ||
|
rmems marked this conversation as resolved.
|
||
| # --- End Aikido local scanner --- | ||
|
|
||
| # --- BEGIN BEADS INTEGRATION v1.0.4 --- | ||
| # This section is managed by beads. Do not remove these markers. | ||
| if command -v bd >/dev/null 2>&1; then | ||
| export BD_GIT_HOOK=1 | ||
| _bd_timeout=${BEADS_HOOK_TIMEOUT:-300} | ||
| if command -v timeout >/dev/null 2>&1; then | ||
| timeout "$_bd_timeout" bd hooks run pre-commit "$@" | ||
| _bd_exit=$? | ||
| if [ $_bd_exit -eq 124 ]; then | ||
| echo >&2 "beads: hook 'pre-commit' timed out after ${_bd_timeout}s — continuing without beads" | ||
| _bd_exit=0 | ||
| fi | ||
| else | ||
| bd hooks run pre-commit "$@" | ||
| _bd_exit=$? | ||
| fi | ||
| if [ $_bd_exit -eq 3 ]; then | ||
| echo >&2 "beads: database not initialized — skipping hook 'pre-commit'" | ||
| _bd_exit=0 | ||
| fi | ||
| if [ $_bd_exit -ne 0 ]; then exit $_bd_exit; fi | ||
| fi | ||
| # --- END BEADS INTEGRATION v1.0.4 --- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| #!/bin/sh | ||
| # Git LFS (optional): skip cleanly when not installed; fail the push if LFS fails. | ||
| if command -v git-lfs >/dev/null 2>&1; then | ||
| git lfs pre-push "$@" | ||
| _lfs_exit=$? | ||
| [ "$_lfs_exit" -eq 0 ] || exit "$_lfs_exit" | ||
| fi | ||
|
|
||
| # --- BEGIN BEADS INTEGRATION v1.0.4 --- | ||
| # This section is managed by beads. Do not remove these markers. | ||
| if command -v bd >/dev/null 2>&1; then | ||
| export BD_GIT_HOOK=1 | ||
| _bd_timeout=${BEADS_HOOK_TIMEOUT:-300} | ||
| if command -v timeout >/dev/null 2>&1; then | ||
| timeout "$_bd_timeout" bd hooks run pre-push "$@" | ||
| _bd_exit=$? | ||
| if [ $_bd_exit -eq 124 ]; then | ||
| echo >&2 "beads: hook 'pre-push' timed out after ${_bd_timeout}s — continuing without beads" | ||
| _bd_exit=0 | ||
| fi | ||
| else | ||
| bd hooks run pre-push "$@" | ||
| _bd_exit=$? | ||
| fi | ||
| if [ $_bd_exit -eq 3 ]; then | ||
| echo >&2 "beads: database not initialized — skipping hook 'pre-push'" | ||
| _bd_exit=0 | ||
| fi | ||
| if [ $_bd_exit -ne 0 ]; then exit $_bd_exit; fi | ||
| fi | ||
| # --- END BEADS INTEGRATION v1.0.4 --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #!/usr/bin/env sh | ||
| # --- BEGIN BEADS INTEGRATION v1.0.4 --- | ||
| # This section is managed by beads. Do not remove these markers. | ||
| if command -v bd >/dev/null 2>&1; then | ||
| export BD_GIT_HOOK=1 | ||
| _bd_timeout=${BEADS_HOOK_TIMEOUT:-300} | ||
| if command -v timeout >/dev/null 2>&1; then | ||
| timeout "$_bd_timeout" bd hooks run prepare-commit-msg "$@" | ||
| _bd_exit=$? | ||
| if [ $_bd_exit -eq 124 ]; then | ||
| echo >&2 "beads: hook 'prepare-commit-msg' timed out after ${_bd_timeout}s — continuing without beads" | ||
| _bd_exit=0 | ||
| fi | ||
| else | ||
| bd hooks run prepare-commit-msg "$@" | ||
| _bd_exit=$? | ||
| fi | ||
| if [ $_bd_exit -eq 3 ]; then | ||
| echo >&2 "beads: database not initialized — skipping hook 'prepare-commit-msg'" | ||
| _bd_exit=0 | ||
| fi | ||
| if [ $_bd_exit -ne 0 ]; then exit $_bd_exit; fi | ||
| fi | ||
| # --- END BEADS INTEGRATION v1.0.4 --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "database": "dolt", | ||
| "backend": "dolt", | ||
| "dolt_mode": "embedded", | ||
| "dolt_database": "limen", | ||
| "project_id": "ffe540b1-a03b-408c-b8dc-c73acd5a44fd" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.