-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Save all podcast episodes to parent folder" option is not compatible with conditional naming #612
Comments
@evan I was recently thinking about this option, and I think I've decided that it is redundant with naming templates and only adds confusion. Personally I think it should be removed, but removing features is... tricky. I would disable that option, and then add this condition to your folder naming template:
|
I was confused about why we had that option myself, seeing as it could be done with the renaming patterns. I'm currently using this naming pattern for the folders:
|
I'm ok with removing the setting. |
Legacy. It was added before naming templates could distinguish between book series and podcasts. As naming templates became more powerful, that option has become more useless.
@rmcrackan What do you think? Removing options is messy business. |
Ah, that makes sense. I only recently discovered Libation, so didn't know it didn't have that functionality to begin with. |
I didn't know it was possible -- so I stopped doing podcasts with Audible,
because that's the only way I was interested (I listen to podcasts by
binding them as audiobooks).
So ... sigh ... although I would have used this if I'd known, I have no
current use for it.
…-Wm
On Tue, May 30, 2023 at 9:32 PM CLHatch ***@***.***> wrote:
I was confused about why we had that option
Legacy. It was added before naming templates could distinguish between
book series and podcasts. As naming templates became more powerful, that
option has become more useless.
I'm ok with removing the setting.
@rmcrackan <https://github.com/rmcrackan> What do you think? Removing
settings is messy business.
Relevant XKCD <https://xkcd.com/1172/>
Ah, that makes sense. I only recently discovered Libation, so didn't know
it didn't have that functionality to begin with.
—
Reply to this email directly, view it on GitHub
<#612 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7H6NW43KAB4HWESVGF43XI3CUNANCNFSM6AAAAAAYUMNHC4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I agree with everything here. It made sense at the time. It doesn't really make sense in light of the if-podcast tag. And there will definitely be someone who want the spacebar heating option. :) What do you think of: we only honor the |
I'm now back to a place where I can explore this issue more thoroughly. First, some facts about the SavePodcastsToParentFolder.
Reflecting a bit more, I think there's room for improvement here and that SavePodcastsToParentFolder still has some value. Some things we could change:
I'm afraid so lol |
Personally, I absolutely love the idea of storing all episodes of a podcast
into a single folder. The outline you've described is exactly what I'd want
for most of the Audible-exclusive podcasts -- consider the serial books
like Alien and so on. You're right that there are challenges, but I wonder
if those would be helped by using the ASIN for the podcast rather than the
one for each episode, and only falling back to the episode if the podcast
didn't work.
…-Wm
On Fri, Jun 2, 2023 at 9:38 AM Mbucari ***@***.***> wrote:
@evan <https://github.com/evan> @rmcrackan <https://github.com/rmcrackan>
I'm now back to a place where I can explore this issue more thoroughly.
First, some facts about the SavePodcastsToParentFolder.
- When Enabled, Libation creates a folder based on the Series's parent
item.
- This item is unique from all podcast episodes and has it's own
Title, Rating, Description, etc.
- This item is identified as a series, but *it is not identified as
a podcast*
- All episodes of a series are placed within that folder, *following
the normal rules for directory and file naming*. This means that A
podcast audio file will be inside two folders: [Series Parent
Folder]/[Episode Folder]/[Episode Audio File]
------------------------------
Reflecting a bit more, I think there's room for improvement here and that
SavePodcastsToParentFolder still has some value.
Some things we could change:
- Make <if series> evaluate true for series parents. This should
probably be done and I thing would fix @evans
<https://github.com/evans>' issue.
- When SavePodcastsToParentFolder is enabled, do not create the [Episode
Folder] so that all episodes are stored in [Series Parent
Folder]/[Episode Audio File]. This could have strange side effects
like:
- The folder thumbnail would be changed after every new podcast is
downloaded
- Some folder tags will not make sense, such as
- <bitrate>
- <channels>
- <series#>
Or did I just create the worst?
I'm afraid so lol
—
Reply to this email directly, view it on GitHub
<#612 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7H6KI732O2Q6SCQNZYSTXJIJGVANCNFSM6AAAAAAYUMNHC4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I'm personally of the save to parent folder persuasion. Mostly because podcasts seem to be the most likely to have length issues. |
This is included in v10.3.3 which will be live within the 1/2 hour. |
I have the following folder format string:
<if podcast->Podcasts/<first author>/<series>/<series#[3]> - <title short><-if podcast><!if podcast->Audiobooks/<first author>/<if series-><series>/<series#[2]> - <-if series><title short><-if podcast>
If the
Save all podcast episodes in a series to the series parent folder?
option is checked, the conditionals do not work, and I get incorrect folder output. With the option unchecked, it works fine.Incorrect:
Correct:
The text was updated successfully, but these errors were encountered: