Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save all podcast episodes to parent folder" option is not compatible with conditional naming #612

Closed
evan opened this issue May 30, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@evan
Copy link

evan commented May 30, 2023

I have the following folder format string:

<if podcast->Podcasts/<first author>/<series>/<series#[3]> - <title short><-if podcast><!if podcast->Audiobooks/<first author>/<if series-><series>/<series#[2]> - <-if series><title short><-if podcast>

If the Save all podcast episodes in a series to the series parent folder? option is checked, the conditionals do not work, and I get incorrect folder output. With the option unchecked, it works fine.

Incorrect:
Incorrect

Correct:
Correct

@evan evan added the bug Something isn't working label May 30, 2023
@Mbucari
Copy link
Collaborator

Mbucari commented May 30, 2023

@evan I was recently thinking about this option, and I think I've decided that it is redundant with naming templates and only adds confusion. Personally I think it should be removed, but removing features is... tricky.

I would disable that option, and then add this condition to your folder naming template:

<if podcast-><series>\<-if podcast>

@CLHatch
Copy link
Contributor

CLHatch commented May 30, 2023

@evan I was recently thinking about this option, and I think I've decided that it is redundant with naming templates and only adds confusion. Personally I think it should be removed, but removing features is... tricky.

I would disable that option, and then add this condition to your folder naming template:

<if podcast-><series>\<-if podcast>

I was confused about why we had that option myself, seeing as it could be done with the renaming patterns. I'm currently using this naming pattern for the folders:

<account>\<if podcast->Podcasts\<if series-><series>\<-if series>(<pub date>) - <title> [<id>] {<narrator[separator(; )]>}<-if podcast><!if podcast->AudioBooks\<author[separator(; )]>\<if series-><series>\<series#[2]> - <-if series>(<year>) - <title> [<id>] {<narrator[separator(; )]>}<-if podcast>

@evan
Copy link
Author

evan commented May 30, 2023

I'm ok with removing the setting.

@Mbucari
Copy link
Collaborator

Mbucari commented May 31, 2023

I was confused about why we had that option

Legacy. It was added before naming templates could distinguish between book series and podcasts. As naming templates became more powerful, that option has become more useless.

I'm ok with removing the setting.

@rmcrackan What do you think? Removing options is messy business.

Relevant XKCD

@CLHatch
Copy link
Contributor

CLHatch commented May 31, 2023

I was confused about why we had that option

Legacy. It was added before naming templates could distinguish between book series and podcasts. As naming templates became more powerful, that option has become more useless.

I'm ok with removing the setting.

@rmcrackan What do you think? Removing settings is messy business.

Relevant XKCD

Ah, that makes sense. I only recently discovered Libation, so didn't know it didn't have that functionality to begin with.

@wtanksleyjr
Copy link
Contributor

wtanksleyjr commented May 31, 2023 via email

@rmcrackan
Copy link
Owner

I agree with everything here. It made sense at the time. It doesn't really make sense in light of the if-podcast tag. And there will definitely be someone who want the spacebar heating option. :)

@Mbucari

What do you think of: we only honor the Save all podcast episodes in a series to the series parent folder? option if if-podcast is not present in any template? Could this be the best of both worlds? Or did I just create the worst?

@Mbucari
Copy link
Collaborator

Mbucari commented Jun 2, 2023

@evan @rmcrackan

I'm now back to a place where I can explore this issue more thoroughly.

First, some facts about the SavePodcastsToParentFolder.

  • When Enabled, Libation creates a folder based on the Series's parent item.
    • This item is unique from all podcast episodes and has it's own Title, Rating, Description, etc.
    • This item is identified as a series, but it is not identified as a podcast
  • All episodes of a series are placed within that folder, following the normal rules for directory and file naming. This means that A podcast audio file will be inside two folders: [Series Parent Folder]/[Episode Folder]/[Episode Audio File]

Reflecting a bit more, I think there's room for improvement here and that SavePodcastsToParentFolder still has some value.

Some things we could change:

  • Make <if series> evaluate true for series parents. This should probably be done and I thing would fix @evans' issue.
  • When SavePodcastsToParentFolder is enabled, do not create the [Episode Folder] so that all episodes are stored in [Series Parent Folder]/[Episode Audio File]. This could have strange side effects like:
    • The folder thumbnail would be changed after every new podcast is downloaded
    • Some folder tags will not make sense, such as
      • <bitrate>
      • <channels>
      • <series#>

Or did I just create the worst?

I'm afraid so lol

@wtanksleyjr
Copy link
Contributor

wtanksleyjr commented Jun 2, 2023 via email

@CharlieRussel
Copy link

I'm personally of the save to parent folder persuasion. Mostly because podcasts seem to be the most likely to have length issues.

@rmcrackan
Copy link
Owner

This is included in v10.3.3 which will be live within the 1/2 hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants