Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid requiring client to instantiate a List #230

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

rmartin16
Copy link
Owner

@rmartin16 rmartin16 commented Jun 9, 2023

Changes

  • Lists, such as TorrentInfoList, will no longer bind the relevant Client
  • This avoids problems when a List method creates a new instance such as when slicing or copying.

@rmartin16 rmartin16 changed the title Avoid requiring client to instantiate a List Avoid requiring client to instantiate a List Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #230 (389059b) into main (8696b63) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #230   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1956      1957    +1     
  Branches       568       568           
=========================================
+ Hits          1956      1957    +1     
Impacted Files Coverage Δ
src/qbittorrentapi/definitions.py 100.00% <100.00%> (ø)
src/qbittorrentapi/log.py 100.00% <100.00%> (ø)
src/qbittorrentapi/search.py 100.00% <100.00%> (ø)
src/qbittorrentapi/torrents.py 100.00% <100.00%> (ø)

@rmartin16 rmartin16 force-pushed the no-list-client branch 3 times, most recently from f57afea to fb92460 Compare June 9, 2023 15:47
@rmartin16 rmartin16 mentioned this pull request Jun 9, 2023
@rmartin16 rmartin16 force-pushed the no-list-client branch 3 times, most recently from 5648d41 to 79f43d9 Compare June 9, 2023 16:31
@rmartin16 rmartin16 merged commit 4f14884 into main Jun 9, 2023
@rmartin16 rmartin16 deleted the no-list-client branch June 9, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant