WIP - Handle changes done in the Devfile library [1]

We'll need to remove this commit and update the Devfile library once [1] is merged.

[1] devfile/library#169

go.mod

@@ -211,3 +211,6 @@ require (
 replace gopkg.in/segmentio/analytics-go.v3 => github.com/segmentio/analytics-go/v3 v3.2.1
 
 replace github.com/apcera/gssapi => github.com/openshift/gssapi v0.0.0-20161010215902-5fb4217df13b
+
+// TODO(rm3l): This is just for testing https://github.com/devfile/library/pull/169
+replace github.com/devfile/library/v2 v2.2.1-0.20230323124903-d36e409ff94f => github.com/kim-tsao/library/v2 v2.0.0-20230327215851-415f3504fb8e

pkg/devfile/devfile.go

@@ -2,11 +2,11 @@ package devfile
 
 import (
 	"fmt"
-
 	"strings"
 
 	"github.com/devfile/library/v2/pkg/devfile"
 	"github.com/devfile/library/v2/pkg/devfile/parser"
+	"k8s.io/utils/pointer"
 
 	"github.com/redhat-developer/odo/pkg/devfile/validate"
 	"github.com/redhat-developer/odo/pkg/log"
@@ -52,8 +52,9 @@ func ParseAndValidateFromFile(devfilePath string) (parser.DevfileObj, error) {
 // if there are warning it logs them on stdout
 func ParseAndValidateFromFileWithVariables(devfilePath string, variables map[string]string) (parser.DevfileObj, error) {
 	return parseDevfile(parser.ParserArgs{
-		Path:              devfilePath,
-		ExternalVariables: variables,
+		Path:               devfilePath,
+		ExternalVariables:  variables,
+		SetBooleanDefaults: pointer.Bool(false),
 	})
 }
 

tests/helper/helper_devfile.go

@@ -70,7 +70,11 @@ func UpdateDevfileContent(path string, handlers []DevfileUpdater) {
 		return
 	}
 
-	d, err := parser.ParseDevfile(parser.ParserArgs{Path: path, FlattenedDevfile: pointer.Bool(false)})
+	d, err := parser.ParseDevfile(parser.ParserArgs{
+		Path:               path,
+		FlattenedDevfile:   pointer.Bool(false),
+		SetBooleanDefaults: pointer.Bool(false),
+	})
 	Expect(err).NotTo(HaveOccurred())
 	for _, h := range handlers {
 		err = h(&d)

tests/integration/cmd_devfile_deploy_test.go

@@ -13,9 +13,10 @@ import (
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	"github.com/onsi/gomega/gexec"
-	"github.com/redhat-developer/odo/pkg/labels"
 	"k8s.io/utils/pointer"
 
+	"github.com/redhat-developer/odo/pkg/labels"
+
 	segment "github.com/redhat-developer/odo/pkg/segment/context"
 	"github.com/redhat-developer/odo/tests/helper"
 )
@@ -728,7 +729,7 @@ CMD ["npm", "start"]
 			})
 		})
 
-		When("running odo dev with some components referenced in the Devfile", func() {
+		When("running odo deploy with some components referenced in the Devfile", func() {
 			var stdout string
 
 			BeforeEach(func() {

vendor/modules.txt

@@ -146,8 +146,8 @@ github.com/devfile/api/v2/pkg/utils/overriding
 github.com/devfile/api/v2/pkg/utils/unions
 github.com/devfile/api/v2/pkg/validation
 github.com/devfile/api/v2/pkg/validation/variables
-# github.com/devfile/library/v2 v2.2.1-0.20230323124903-d36e409ff94f
-## explicit; go 1.15
+# github.com/devfile/library/v2 v2.2.1-0.20230323124903-d36e409ff94f => github.com/kim-tsao/library/v2 v2.0.0-20230327215851-415f3504fb8e
+## explicit; go 1.18
 github.com/devfile/library/v2/pkg/devfile
 github.com/devfile/library/v2/pkg/devfile/generator
 github.com/devfile/library/v2/pkg/devfile/parser