Skip to content

create breaking changes#9

Closed
rluvaton wants to merge 42 commits intomainfrom
remove-api
Closed

create breaking changes#9
rluvaton wants to merge 42 commits intomainfrom
remove-api

Conversation

@rluvaton
Copy link
Copy Markdown
Owner

@rluvaton rluvaton commented Apr 27, 2026

NOTE: main was pushed so the changes in this files changed are not matching what I tested which was removing function, rename, add args
all of which was merged to my fork main as a temp

rluvaton and others added 30 commits April 9, 2026 12:00
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rluvaton and others added 2 commits April 27, 2026 12:50
Temporary instrumentation to figure out why the changed-crates step is
returning empty in CI when the diff clearly contains files under
published crate directories.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Repository owner deleted a comment from github-actions Bot Apr 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes made since the last release.

Details:

     Cloning origin/main
    Building datafusion v53.0.0 (current)
       Built [  68.587s] (current)
     Parsing datafusion v53.0.0 (current)
      Parsed [   0.030s] (current)
    Building datafusion v53.0.0 (baseline)
       Built [  67.104s] (baseline)
     Parsing datafusion v53.0.0 (baseline)
      Parsed [   0.030s] (baseline)
    Checking datafusion v53.0.0 -> v53.0.0 (no change; assume patch)
     Checked [   0.733s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron

Failed in:
  function datafusion::call, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-origin_main/ed0765943d1ef64f15902e44a47669529df516cf/datafusion/core/src/lib.rs:894

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [ 138.704s] datafusion
    Building datafusion-execution v53.0.0 (current)
       Built [  21.705s] (current)
     Parsing datafusion-execution v53.0.0 (current)
      Parsed [   0.021s] (current)
    Building datafusion-execution v53.0.0 (baseline)
       Built [  22.172s] (baseline)
     Parsing datafusion-execution v53.0.0 (baseline)
      Parsed [   0.022s] (baseline)
    Checking datafusion-execution v53.0.0 -> v53.0.0 (no change; assume patch)
     Checked [   0.230s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron

Failed in:
  datafusion_execution::this_new_exec now takes 1 parameters instead of 0, in /home/runner/work/datafusion/datafusion/datafusion/execution/src/lib.rs:53

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  45.123s] datafusion-execution
    Building datafusion-functions-nested v53.0.0 (current)
       Built [  27.114s] (current)
     Parsing datafusion-functions-nested v53.0.0 (current)
      Parsed [   0.030s] (current)
    Building datafusion-functions-nested v53.0.0 (baseline)
       Built [  27.060s] (baseline)
     Parsing datafusion-functions-nested v53.0.0 (baseline)
      Parsed [   0.030s] (baseline)
    Checking datafusion-functions-nested v53.0.0 -> v53.0.0 (no change; assume patch)
     Checked [   0.172s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron

Failed in:
  function datafusion_functions_nested::call_function_nested, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-origin_main/ed0765943d1ef64f15902e44a47669529df516cf/datafusion/functions-nested/src/lib.rs:195

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  55.407s] datafusion-functions-nested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant