-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/heat load #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! Looks very good already. Here are some comments - haven't tested yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, @MaGering! Looks pretty good already. Some things can be cleaned up a bit still (see the individual comments).
…prepare_heat_demand.py
… decentral in carrier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort, @MaGering! Much of it looks quite good and is on the right track. Some things can be improved and should be improved - see my suggestions. Please make sure that the script runs successfully - I tried to test it but it failed to complete.
|
||
if __name__ == "__main__": | ||
in_path1 = sys.argv[1] # path to weather data | ||
in_path2 = sys.argv[2] # path to household distributions data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Household distribution data is not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
total_heat_load = postprocess_data( | ||
total_heat_load, heat_load_year, region, f"ts_{year}", sc_demand_unit | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a function here that sums up the scalars for hh, ghd and i?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaGering: Can you please have a final check to make sure that the prepared scalars and timeseries are correct? After that, the filenames have to be cleaned up - then we can merge. |
Thanks for the adjustments! It runs through and the outputs look good to me. Should I change |
No, the naming should stay - the script now produces both scalars and timeseries. |
Resolves #53 by adding a function that calculates heat load profiles.
Hence the demandlib is used to calculate profiles for households and GHD, the
install_requires
insetup.py
and snakemake rule insnakemake
file are updated as well.