Slack Incoming Webhooks instructions / interface has changed #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
∙ Defaults can be configured per incoming-webhook via Slack; these options only add confusion, since neither echoChannel nor botName can change dynamically.
liyang
force-pushed
the
master
branch
4 times, most recently
from
f12e790 to
6ace2ce
Compare
∙ Also console.log() the exact message sent to Slack, rather than a completely different format: this is more useful. ∘ Was this copypasta from the "bot.js" example from the "irc" package? ∙ Pass the unadulterated message to handCommand(): for the mapped nicks, it can always perform the mapping again; the reverse is much more awkward. ∙ config.irc.nick isn't necessarily our assigned nick; client.nick instead. ∙ I don't understand why there was an unnecessary "var room = to;"
∙ Prevents e.g. ‘foobar’↦‘soapbar’ when there's an entry of ‘foo’↦‘soap’. ∘ Schoolboy regex oversight.
∙ There can be only one channel. So why bother?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all incoming requests go to
hooks.slack.com, and the hook setup instructions doesn't refer to a ‘token’ any more.I removed the 'channel' and 'username' options because this script cannot mirror to than one Slack channel at a time—nor does the channel / bot username ever change—and in any case can be configured via the defaults on the Slack hook configuration interface when setting one up.
Also, if a mapped nick speaks on IRC, the 'from' variable wasn't being mapped to the corresponding Slack nick.
Also, I improved the nick mapping by only matching on word boundaries.
Also, I took the liberty of adding support for '/me derps.'
Also, I decided to replace the
[#irc-channel]tag from the text sent to Slack, since we do not monitor more than one channel per instance. Instead, we tags private messages to the bot as such.Feel free to take any or all of the above. Or let me know which changes you're not sure about and I'll remove them from this PR.