-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Allow schema $refs to not have to start with #/definitions
#954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
domharrington
wants to merge
10
commits into
rjsf-team:master
from
domharrington:feature/definitions-improvements
Closed
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2c887bc
Move some mocha options to mocha.opts
f518abc
Allow schema $refs to not have to start with `#/definitions`
4d09c10
Merge branch 'master' into feature/definitions-improvements
d8b5e3a
Add wrapper element around required asterisk in TitleField
c551ecd
Merge branch 'master' of https://github.com/mozilla-services/react-js…
domharrington a4512c6
Merge branch 'master' of https://github.com/mozilla-services/react-js…
domharrington fd03c01
Merge branch 'master' of https://github.com/mozilla-services/react-js…
domharrington b48a56a
Merge branch 'master' into feature/definitions-improvements
domharrington f426b06
Merge branch 'master' of https://github.com/mozilla-services/react-js…
domharrington a71e66c
Merge branch 'master' into feature/definitions-improvements
domharrington File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| --timeout 5000 | ||
| --compilers js:babel-register | ||
| --require ./test/setup-jsdom.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes for mocha config, but can you please remove these changes from this PR and make a separate PR for it?