Closed
Conversation
Throwing an error when an extraneous property name is included or when a property name is missing is problematic when ordering properties in a dynamic schema (e.g. via schema dependencies, etc.). This change ignores extraneous property names and places places missing properties at the end if not specified.
Contributor
Contributor
Author
|
I just got done looking at those refs. Thank you. If I understand correctly, you would like for an error to be shown for any extraneous property name that is not in the schema properties nor any conditional schema properties defined in dependencies. That seems doable. |
Member
@mfulton26 I'm closing this for now, if you would like to implement the behavior mentioned above, please make another PR. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwing an error when an extraneous property name is included
or when a property name is missing is problematic when ordering
properties in a dynamic schema (e.g. via schema dependencies,
etc.).
This change ignores extraneous property names and places places
missing properties at the end if not specified.
Reasons for making this change
[Please describe them here]
If this is related to existing tickets, include links to them as well.
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style