Define registryShape and use it as a prop type#777
Closed
anlesk wants to merge 2 commits intorjsf-team:masterfrom
anlesk:prop-types-registry
Closed
Define registryShape and use it as a prop type#777anlesk wants to merge 2 commits intorjsf-team:masterfrom anlesk:prop-types-registry
anlesk wants to merge 2 commits intorjsf-team:masterfrom
anlesk:prop-types-registry
Conversation
Contributor
Author
|
Well, I've run cs-format locally and it seems that the pre-commit task overrides some changes. |
Contributor
Author
|
It appears that running precommit scripts on node 8x leads to unexpected precommit code changes. |
Collaborator
|
This MR looks goot do me. |
Member
|
This was implemented in #1118 (see https://github.com/mozilla-services/react-jsonschema-form/pull/1118/files#diff-3a699a0719518f967e9b2df3f5549e02R3), so closing your PR. Sorry this PR wasn't merged in time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
With #699 being merged to master, registry became a mandatory parameter for most widgets and fields.
registryShapeis being defined and used as a custom shape in components.Checklist
npm run cs-formaton my branch to conform my code to prettier coding style