Skip to content

Define registryShape and use it as a prop type#777

Closed
anlesk wants to merge 2 commits intorjsf-team:masterfrom
anlesk:prop-types-registry
Closed

Define registryShape and use it as a prop type#777
anlesk wants to merge 2 commits intorjsf-team:masterfrom
anlesk:prop-types-registry

Conversation

@anlesk
Copy link
Copy Markdown
Contributor

@anlesk anlesk commented Nov 27, 2017

Reasons for making this change

With #699 being merged to master, registry became a mandatory parameter for most widgets and fields.
registryShape is being defined and used as a custom shape in components.

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@anlesk
Copy link
Copy Markdown
Contributor Author

anlesk commented Nov 27, 2017

Well, I've run cs-format locally and it seems that the pre-commit task overrides some changes.

@anlesk
Copy link
Copy Markdown
Contributor Author

anlesk commented Nov 29, 2017

It appears that running precommit scripts on node 8x leads to unexpected precommit code changes.
I was able to successfully commit with node 6x.

@edi9999
Copy link
Copy Markdown
Collaborator

edi9999 commented Jan 11, 2018

This MR looks goot do me.

@epicfaace
Copy link
Copy Markdown
Member

This was implemented in #1118 (see https://github.com/mozilla-services/react-jsonschema-form/pull/1118/files#diff-3a699a0719518f967e9b2df3f5549e02R3), so closing your PR. Sorry this PR wasn't merged in time.

@epicfaace epicfaace closed this Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants