Skip to content

Issue #411. Enable required field on radio options.#469

Merged
n1k0 merged 1 commit intorjsf-team:masterfrom
crumblix:Issue-411
Feb 14, 2017
Merged

Issue #411. Enable required field on radio options.#469
n1k0 merged 1 commit intorjsf-team:masterfrom
crumblix:Issue-411

Conversation

@crumblix
Copy link
Copy Markdown
Collaborator

@crumblix crumblix commented Feb 14, 2017

Reasons for making this change

Enabled the required field on radio options so we can utilise HTML5 validation, as raised in Issue 411.

Tested on:
numberEnumRadio on the "Numbers" tab in the playground
"boolean"."radio" in th "Widgets" tab in the playground

with noHtml5Validate both on and off

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@n1k0 n1k0 merged commit 8b2f966 into rjsf-team:master Feb 14, 2017
@n1k0
Copy link
Copy Markdown
Collaborator

n1k0 commented Feb 14, 2017

👍

n1k0 added a commit that referenced this pull request Feb 22, 2017
Highlights
---

- Improved performance and reactivity.
- More consistent validation behavior and UX for array field items.

Backward incompatible changes
---

- `ObjectField` and `ArrayField` are now stateless components, their
  local state handling has been dropped entirely, resulting in large
  performance improvements.
- The `defaultFieldValue` helper from the `utils` module has been
  removed, as it wasn't used anymore.

New features
---

* Fix #411:  Enable required field on radio options. (#469)
* Spread `formContext` to `ArrayTemplateField`, `files` and `multiselect`
  arrays (#456)
* From #471: Non-nullable array item fields are now marked as required in
  the UI.

Bugfixes
---

* Don't pass consumed `SchemaField` class names to child component (#439)
* Turn `ObjectField` and `ArrayField` into stateless components (#480)
* Fix #471: Drop default value initialization at the widget level. (#476)

Kudos
---

Special thanks to @crumblix and @knilink for their help on this release.
You guys rock!
@n1k0
Copy link
Copy Markdown
Collaborator

n1k0 commented Feb 22, 2017

Released in v0.43.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants