Conversation
d210385 to
1a8c4aa
Compare
epicfaace
left a comment
There was a problem hiding this comment.
Thanks for this change! Do you mind also adding a documentation page called "3.x upgrade guide" that describes the nature of this change, and also what people should do (what polyfills they should install) if they were depending on @babel/runtime-corejs2 that used to be bundled with @rjsf/core?
3c6c0ea to
26d3405
Compare
docs/3.x upgrade guide.md
Outdated
|
|
||
| If you're using a framework like [Create React App](https://create-react-app.dev/docs/supported-browsers-features#supported-browsers), [Gatsby](https://www.gatsbyjs.com/docs/how-to/custom-configuration/browser-support/), or [Next.js](https://nextjs.org/docs/basic-features/supported-browsers-features), polyfills are already included there. | ||
|
|
||
| If you were directly depending on @rjsf/core's @babel/runtime pulling in core-js@2, [@babel/preset-env](https://babeljs.io/docs/en/babel-preset-env#how-does-it-work) is probably a good first choice. |
There was a problem hiding this comment.
Just want to clarify here -- is the only solution here that we have to begin transpiling the code with @babel/preset-env? What if we just ran npm install core-js and added import 'core-js'; -- would that also be a solution?
There was a problem hiding this comment.
I added a note to that effect.
|
@wegry Can you merge master into this branch? Then we should be all ready to merge. |
|
Let me give it a shot @epicfaace. |
4f0dc68 to
2283e99
Compare
Reasons for making this change
Two versions of core-js currently exist in my app because @rjsf/core pulls in @babel/runtime currently. There are two direct imports of core-js that I've opted to pull in pure imports for.
For the rationale of why library code shouldn't include polyfills, this comment
w3ctag/polyfills#6 (comment) explains my rationale. This is a breaking change though, if downstream folks were depending on
@babel/runtimebeing around.If this is related to existing tickets, include links to them as well. fixes #1601
Recreates PR for #2049
Checklist