Conversation
stanlemon
reviewed
Jun 15, 2020
| title = schema.title === undefined ? name : schema.title; | ||
| } | ||
|
|
||
| const title = schema.title === undefined ? name : schema.title; |
Contributor
There was a problem hiding this comment.
Not specific to these changes... You might want to make this falsey rather than specifically checking for undefined, in case a schema.title is set as false or null. I admit, that would be weird, but I think you'd still want to default to name there.
Member
Author
There was a problem hiding this comment.
Hmm, not quite sure about that. Sometimes it's useful for me to set schema.title = "" in order to show no title (I know there's also a uiSchema option for hiding titles, but perhaps it would make sense if the schema title is set to a falsey value, just to not show a title in that case)?
stanlemon
approved these changes
Jun 15, 2020
anikethsaha
pushed a commit
to MLH-Fellowship/react-jsonschema-form
that referenced
this pull request
Jul 21, 2020
…m#1751) Fixes rjsf-team#1749. This reverts part of rjsf-team#1401 (the conditional setting of the title in the wasPropertyKeyModified logic in ObjectField.js) -- this piece of logic doesn't seem to contribute to the fix in rjsf-team#1401, and it's what caused rjsf-team#1749. Additionally, the test that was added in rjsf-team#1401 didn't actually check to make sure the issue it was solving was resolved; that test passed even before rjsf-team#1401 was merged. The issue that rjsf-team#1401 was that onChange was called with the new key, but the new key did not show up in the DOM. I've updated that test to check for this behavior (updating the new key in the DOM) now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #1749. This reverts part of #1401 (the conditional setting of the title in the
wasPropertyKeyModifiedlogic in ObjectField.js) -- this piece of logic doesn't seem to contribute to the fix in #1401, and it's what caused #1749.Additionally, the test that was added in #1401 didn't actually check to make sure the issue it was solving was resolved; that test passed even before #1401 was merged. The issue that #1401 was that
onChangewas called with the new key, but the new key did not show up in the DOM. I've updated that test to check for this behavior (updating the new key in the DOM) now.@erunion can you review to make sure this all makes sense?