feat: exposing findSchemaDefinition out of the utils lib#1643
Merged
epicfaace merged 1 commit intorjsf-team:masterfrom Mar 14, 2020
erunion:feat/expose-findschemadefinition
Merged
feat: exposing findSchemaDefinition out of the utils lib#1643epicfaace merged 1 commit intorjsf-team:masterfrom erunion:feat/expose-findschemadefinition
epicfaace merged 1 commit intorjsf-team:masterfrom
erunion:feat/expose-findschemadefinition
Conversation
7 tasks
epicfaace
reviewed
Mar 14, 2020
Member
epicfaace
left a comment
There was a problem hiding this comment.
Thanks, that does seem to be a useful util to export.
Still thinking about whether we should actually export utils from the same path / package though -- see #1642 (comment) -- but that's a discussion fro later.
epicfaace
approved these changes
Mar 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Working on some resolving some bugs in a custom
SchemaFieldthat we've got, and I needed access to this so I could parse a$ref. Couldn't use it because it wasn't being exposed!Checklist