Conversation
This was referenced Mar 9, 2020
Merged
Saulzi
reviewed
Mar 10, 2020
Contributor
Saulzi
left a comment
Saulzi
left a comment
There was a problem hiding this comment.
I did the same as this except for I pulled typings in and I found that the material-ui did not work
7 tasks
epicfaace
added a commit
that referenced
this pull request
Mar 16, 2020
Building off of work done in #1606 and #1641. Update build and dev process and documentation (as discussed in #1630 (comment)). The developer will just need to run lerna bootstrap, run npm start from the package they are modifying, then run the playground from packages/playground to get a live-reloading playground. Fix deploy previews by configuring netlify so that it runs lerna bootstrap, thus linking the packages with the local changes in the PR, before building the playground. Export typings from @rjsf/core (fixes #1583) -- did this in this PR so that @rjsf/material-ui would work as well. Fix playground issues in which the material-ui playground did not use the right ObjectFieldTemplate or ArrayFieldTemplate. Fixes #1630 .
edi9999
approved these changes
Apr 5, 2020
Member
|
Can we get a release with these fixes soon? |
Member
Author
|
Soon! |
Member
|
I really hope so, I've just reached the point where this is completely blocking me. Is there anyway I can help? Review a PR or something? |
|
Yes please, so that we may override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Add tests to the material-ui theme so that it can be released.
Also, update the docs to discuss the themes in more detail.
Finally, refactors utils to be exported from the default @rjsf/core package so that they are properly transpiled -- fixes #1655 (this had to be done in order to get material-ui tests to work, so that's why both are done in the same PR)
So, previously an import would look like this:
Now you would need to do this:
Related: #1561 #1585 -- we'd have to get the theme documentation in first before merging these two PRs.